Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3D94E200C8C for ; Tue, 6 Jun 2017 21:47:34 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3C4DE160BC6; Tue, 6 Jun 2017 19:47:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 82F57160BB7 for ; Tue, 6 Jun 2017 21:47:33 +0200 (CEST) Received: (qmail 31870 invoked by uid 500); 6 Jun 2017 19:47:32 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 31859 invoked by uid 99); 6 Jun 2017 19:47:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jun 2017 19:47:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DDD611AFDD6; Tue, 6 Jun 2017 19:47:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.5 X-Spam-Level: *** X-Spam-Status: No, score=3.5 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id EOQsCjzim1Yd; Tue, 6 Jun 2017 19:47:31 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B07175F5B8; Tue, 6 Jun 2017 19:47:30 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 474A2E01A8; Tue, 6 Jun 2017 19:47:30 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 24089C40316; Tue, 6 Jun 2017 19:47:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7554803258189400121==" MIME-Version: 1.0 Subject: Re: Review Request 59726: HIVE-16804 From: Deepak Jaiswal To: Jason Dere Cc: Deepak Jaiswal , hive Date: Tue, 06 Jun 2017 19:47:30 -0000 Message-ID: <20170606194730.32586.12074@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Deepak Jaiswal X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59726/ X-Sender: Deepak Jaiswal References: <20170606005440.26025.86759@reviews-vm2.apache.org> In-Reply-To: <20170606005440.26025.86759@reviews-vm2.apache.org> Reply-To: Deepak Jaiswal X-ReviewRequest-Repository: hive-git archived-at: Tue, 06 Jun 2017 19:47:34 -0000 --===============7554803258189400121== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59726/ ----------------------------------------------------------- (Updated June 6, 2017, 7:47 p.m.) Review request for hive and Jason Dere. Changes ------- Fixed the issue found by Jason in the test. Bugs: HIVE-16804 https://issues.apache.org/jira/browse/HIVE-16804 Repository: hive-git Description ------- Currently the semijoin hint takes source table input. However, to provide better control, also provide the target table name in hint. The Target field is added as a mandatory parameter. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java 8a62982e1e ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d514644da0 ql/src/java/org/apache/hadoop/hive/ql/parse/SemiJoinHint.java f7fd306a2c ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 7e156f610a ql/src/test/queries/clientpositive/semijoin_hint.q 71fa445ec8 ql/src/test/results/clientpositive/llap/semijoin_hint.q.out ae9bf9bd8b Diff: https://reviews.apache.org/r/59726/diff/3/ Changes: https://reviews.apache.org/r/59726/diff/2-3/ Testing ------- Thanks, Deepak Jaiswal --===============7554803258189400121==--