Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3644E200CA3 for ; Thu, 1 Jun 2017 23:00:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 34D99160BC4; Thu, 1 Jun 2017 21:00:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7BF1A160BC1 for ; Thu, 1 Jun 2017 23:00:09 +0200 (CEST) Received: (qmail 75863 invoked by uid 500); 1 Jun 2017 21:00:08 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 75851 invoked by uid 99); 1 Jun 2017 21:00:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Jun 2017 21:00:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DC0571AFB19; Thu, 1 Jun 2017 21:00:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id UNcfT8s4qiOn; Thu, 1 Jun 2017 21:00:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7A45E5FC6C; Thu, 1 Jun 2017 21:00:06 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1F254E0185; Thu, 1 Jun 2017 21:00:06 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id EC926C40295; Thu, 1 Jun 2017 21:00:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0901928850114933648==" MIME-Version: 1.0 Subject: Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false From: pengcheng xiong To: Ashutosh Chauhan Cc: pengcheng xiong , hive Date: Thu, 01 Jun 2017 21:00:05 -0000 Message-ID: <20170601210005.14946.30151@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: pengcheng xiong X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59697/ X-Sender: pengcheng xiong References: <20170601194637.14946.60038@reviews-vm2.apache.org> In-Reply-To: <20170601194637.14946.60038@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/perf/query74.q.out X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/perf/query4.q.out X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/perf/query74.q X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/filter_aggr.q.out X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/filter_aggr.q X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/perf/query4.q Reply-To: pengcheng xiong X-ReviewRequest-Repository: hive-git archived-at: Thu, 01 Jun 2017 21:00:10 -0000 --===============0901928850114933648== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59697/#review176661 ----------------------------------------------------------- ql/src/test/results/clientpositive/filter_aggr.q.out Lines 266 (patched) This shows null scan optimization is in. - pengcheng xiong On June 1, 2017, 7:46 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59697/ > ----------------------------------------------------------- > > (Updated June 1, 2017, 7:46 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > hive-16775 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterAggregateTransposeRule.java 0e5c7313b6 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 7f583ed075 > ql/src/test/queries/clientpositive/filter_aggr.q PRE-CREATION > ql/src/test/queries/clientpositive/perf/query4.q PRE-CREATION > ql/src/test/queries/clientpositive/perf/query74.q PRE-CREATION > ql/src/test/results/clientpositive/filter_aggr.q.out PRE-CREATION > ql/src/test/results/clientpositive/perf/query4.q.out PRE-CREATION > ql/src/test/results/clientpositive/perf/query74.q.out PRE-CREATION > > > Diff: https://reviews.apache.org/r/59697/diff/2/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > > --===============0901928850114933648==--