hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Shelukhin <ser...@hortonworks.com>
Subject Re: Review Request 60478: HIVE-16761 LLAP IO: SMB joins fail elevator
Date Tue, 27 Jun 2017 21:47:39 GMT
See the above comment. Will uncomment when I can run the test with correct result to verify
:)

From: Deepak Jaiswal <noreply@reviews.apache.org<mailto:noreply@reviews.apache.org>>
on behalf of Deepak Jaiswal <djaiswal@hortonworks.com<mailto:djaiswal@hortonworks.com>>
Reply-To: Deepak Jaiswal <djaiswal@hortonworks.com<mailto:djaiswal@hortonworks.com>>
Date: Tuesday, June 27, 2017 at 14:45
To: Deepak Jaiswal <djaiswal@hortonworks.com<mailto:djaiswal@hortonworks.com>>
Cc: Sergey Shelukhin <sergey@hortonworks.com<mailto:sergey@hortonworks.com>>,
"dev@hive.apache.org<mailto:dev@hive.apache.org>" <dev@hive.apache.org<mailto:dev@hive.apache.org>>
Subject: Re: Review Request 60478: HIVE-16761 LLAP IO: SMB joins fail elevator

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60478/


Looks good to me. Can you please address one minor comment?

llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java<https://reviews.apache.org/r/60478/diff/1/?file=1764267#file1764267line197>(Diff
revision 1)

        183

    // TODO: try to find the fake merge work for SMB join, that is really another MapWork.


Why is this code block commented out? Is it not needed anymore?


- Deepak Jaiswal


On June 27th, 2017, 6:24 p.m. UTC, Sergey Shelukhin wrote:

Review request for hive and Deepak Jaiswal.
By Sergey Shelukhin.

Updated June 27, 2017, 6:24 p.m.

Repository: hive-git
Description

see jira


Diffs

  *   itests/src/test/resources/testconfiguration.properties (0aadee3e3d)
  *   llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java (c22d446320)
  *   llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java (d4e14a88c2)
  *   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java (e546a658c7)
  *   ql/src/test/queries/clientpositive/llap_smb.q (PRE-CREATION)
  *   ql/src/test/results/clientpositive/llap/llap_smb.q.out (PRE-CREATION)

View Diff<https://reviews.apache.org/r/60478/diff/1/>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message