hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vineet Garg <vg...@hortonworks.com>
Subject Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates
Date Tue, 27 Jun 2017 23:12:29 GMT


> On June 27, 2017, 9:24 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/subquery_in.q.out
> > Lines 5531-5540 (patched)
> > <https://reviews.apache.org/r/59984/diff/1-2/?file=1747778#file1747778line5623>
> >
> >     Change in resultset. Either earlier results were wrong or new one.

Thanks for catching this. I missed it because i was comparing it with master!


- Vineet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59984/#review179052
-----------------------------------------------------------


On June 26, 2017, 8:41 p.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59984/
> -----------------------------------------------------------
> 
> (Updated June 26, 2017, 8:41 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-16838
>     https://issues.apache.org/jira/browse/HIVE-16838
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This patch improves plans for subqueries which have not equal corelated predicates. 
> Currently to retrieve all possible correlated predicates inner table is joined with outer
query. This is un-necessary in most of the cases (exception is if subquery has an aggregate).
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java
63bbdaccfb 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveIntersect.java
19e1e026f4 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveUnion.java
7cfb007a9d 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java
4c99932759 
>   ql/src/test/queries/clientpositive/subquery_in.q 4ba170a706 
>   ql/src/test/results/clientpositive/constprog_partitioner.q.out 8c7f9d3f29 
>   ql/src/test/results/clientpositive/llap/explainuser_1.q.out e78ceb3a4c 
>   ql/src/test/results/clientpositive/llap/subquery_exists.q.out 3004e36c9d 
>   ql/src/test/results/clientpositive/llap/subquery_in.q.out b3d735afb9 
>   ql/src/test/results/clientpositive/llap/subquery_multi.q.out 718bc13ed4 
>   ql/src/test/results/clientpositive/llap/subquery_notin.q.out d10fd84a3a 
>   ql/src/test/results/clientpositive/llap/subquery_scalar.q.out ceccc88b2e 
>   ql/src/test/results/clientpositive/llap/subquery_select.q.out 440e9d7b55 
>   ql/src/test/results/clientpositive/llap/subquery_views.q.out ad199e2336 
>   ql/src/test/results/clientpositive/llap/vector_mapjoin_reduce.q.out 8aabb62b9e 
>   ql/src/test/results/clientpositive/perf/query16.q.out 239f2b7236 
>   ql/src/test/results/clientpositive/perf/query94.q.out 9cc934fd1b 
>   ql/src/test/results/clientpositive/spark/constprog_partitioner.q.out 3467215d63 
>   ql/src/test/results/clientpositive/spark/subquery_exists.q.out 8768b45166 
>   ql/src/test/results/clientpositive/spark/subquery_in.q.out ae4e6fb4f4 
>   ql/src/test/results/clientpositive/spark/vector_mapjoin_reduce.q.out 433b9a2880 
>   ql/src/test/results/clientpositive/subquery_exists.q.out cfc76520ce 
>   ql/src/test/results/clientpositive/subquery_exists_having.q.out 2c41ff6c33 
>   ql/src/test/results/clientpositive/subquery_in_having.q.out 2bb812cd73 
>   ql/src/test/results/clientpositive/subquery_notexists.q.out 039df03819 
>   ql/src/test/results/clientpositive/subquery_notexists_having.q.out fda801d387 
>   ql/src/test/results/clientpositive/subquery_notin_having.q.out 462dda5e14 
>   ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out 03eb4b6ba4 
>   ql/src/test/results/clientpositive/vector_mapjoin_reduce.q.out 0ff11df8a3 
> 
> 
> Diff: https://reviews.apache.org/r/59984/diff/2/
> 
> 
> Testing
> -------
> 
> * Added new tests
> * Pre-commit testing
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message