hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Barna Zsombor Klara <zsombor.kl...@cloudera.com>
Subject Re: Review Request 60355: HIVE-16929 User-defined UDF functions can be registered as invariant functions
Date Thu, 22 Jun 2017 08:17:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60355/#review178639
-----------------------------------------------------------



Thank you for the patch ZhangBing Lin. I only had a few minor comments and nits.
Since you are adding several utility methods, do you think it would be possible to add a few
unit tests?
Thanks!


common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 3475 (patched)
<https://reviews.apache.org/r/60355/#comment252787>

    nit: packagename*s*. I think you meant to use the plural.



ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
Line 22 (original), 22 (patched)
<https://reviews.apache.org/r/60355/#comment252785>

    Let's respect the Hive coding standards, please list all the imports instead of using
the wildcard.



ql/src/java/org/apache/hadoop/hive/ql/util/ClassUtil.java
Lines 38 (patched)
<https://reviews.apache.org/r/60355/#comment252795>

    Could we get a javadoc here? Based on the method at a glance I'm not sure if this method
will list all implementing classes or just the ones from the same package.



ql/src/java/org/apache/hadoop/hive/ql/util/ClassUtil.java
Lines 56 (patched)
<https://reviews.apache.org/r/60355/#comment252797>

    nit: Could we return an empty list instead on null to avoid NPEs?



ql/src/java/org/apache/hadoop/hive/ql/util/ClassUtil.java
Lines 110 (patched)
<https://reviews.apache.org/r/60355/#comment252796>

    Can we log this out instead of just writing to the err stream? Same on line 117,122 and
149.



ql/src/java/org/apache/hadoop/hive/ql/util/UDFRegister.java
Lines 40 (patched)
<https://reviews.apache.org/r/60355/#comment252791>

    nit: Should this be a warning instead of info?


- Barna Zsombor Klara


On June 22, 2017, 3:18 a.m., ZhangBing Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60355/
> -----------------------------------------------------------
> 
> (Updated June 22, 2017, 3:18 a.m.)
> 
> 
> Review request for hive, cheng xu and Xuefu Zhang.
> 
> 
> Bugs: HIVE-16929
>     https://issues.apache.org/jira/browse/HIVE-16929
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Add a configuration item "hive.aux.udf.package.name.list" in hive-site.xml, which is
a scan corresponding to the $HIVE_HOME/auxlib/ directory jar package that contains the corresponding
configuration package name under the class registered as a constant function.
> Such as,
> <property>
>   <name>hive.aux.udf.package.name.list</name>
>   <value>com.sample.udf,com.test.udf</value>
> </property>
> Instructions:
>    1, upload your jar file to $ HIVE_HOME/auxlib
>    2, configure your UDF function corresponding to the package to the following configuration
parameters
>    <property>
>         <name>hive.aux.udf.package.name.list</name>
>         <value>com.sample.udf</value>
>    </property>
>   
>    3, the configuration items need to be placed in the hive-site.xml file
>    4, restart the Hive service to take effect
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a8bdefdad6 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 9795f3ef98 
>   ql/src/java/org/apache/hadoop/hive/ql/util/ClassUtil.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/util/UDFRegister.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60355/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> ZhangBing Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message