hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <pv...@cloudera.com>
Subject Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client
Date Wed, 14 Jun 2017 14:36:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60085/#review177889
-----------------------------------------------------------



Thanks Zsombor for the patch.

Overall looks good to me, just one comment.

Thanks,
Peter


testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
Lines 38-39 (patched)
<https://reviews.apache.org/r/60085/#comment251587>

    Would be nice to have a usage comment somewhere


- Peter Vary


On June 14, 2017, 2:04 p.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60085/
> -----------------------------------------------------------
> 
> (Updated June 14, 2017, 2:04 p.m.)
> 
> 
> Review request for hive, Marta Kuczora, Peter Vary, and Sergio Pena.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client
> 
> 
> Diffs
> -----
> 
>   testutils/ptest2/conf/deployed/master-mr2.properties 05c040599172caf9d67c4e27affce12a335dab4b

>   testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java 8e2604d372ac29b94445b269f08423b058308efe

>   testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java
8deed52ae0307d4fc075654a4d75e6cb09a5d9db 
>   testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a

>   testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60

>   testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
e584f9c105fa134e3e267d6c6817d441b4c6b249 
>   testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java
848faf27af1ed8945d7013b6562bab544605e4bc 
> 
> 
> Diff: https://reviews.apache.org/r/60085/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested PTestClient.
> Updated unit tests for the code in TestConfiguration.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message