hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Barna Zsombor Klara <zsombor.kl...@cloudera.com>
Subject Re: Review Request 59629: HIVE-14745: Remove jira user/password from profiles by using another command to submit results to jira
Date Tue, 13 Jun 2017 15:00:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59629/
-----------------------------------------------------------

(Updated June 13, 2017, 3 p.m.)


Review request for hive, Sergio Pena and Siddharth Seth.


Changes
-------

Updated based on Peter's review. Thank you!


Bugs: HIVE-14745
    https://issues.apache.org/jira/browse/HIVE-14745


Repository: hive-git


Description
-------

Added the ability to write data needed for the jira comment into json.
Refactored the TestStatus response to contain the generated jira comment.
Refactored the PTestClient to take the jira comment from the last TestStatus response which
is either a success or a failure and post it to the Jira Service.


Diffs (updated)
-----

  testutils/ptest2/conf/deployed/master-mr2.properties 05c040599172caf9d67c4e27affce12a335dab4b

  testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java 8e2604d372ac29b94445b269f08423b058308efe

  testutils/ptest2/src/main/java/org/apache/hive/ptest/api/common/JiraCommentPoster.java PRE-CREATION

  testutils/ptest2/src/main/java/org/apache/hive/ptest/api/response/TestStatus.java 7dfadb42edbb8526b169d3034e01d0e8e8739fdf

  testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java
2f96ad03023e9f51d44d203f34edd04183605a22 
  testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/Test.java 7fbabd96d8c9a443bb5cfd2defe7a10510cf9a15

  testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a

  testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java ff1dbd4bafaba9a0e88321c6507a47bbe0421833

  testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60

  testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
e584f9c105fa134e3e267d6c6817d441b4c6b249 
  testutils/ptest2/src/test/java/org/apache/hive/ptest/api/client/TestPTestClient.java PRE-CREATION

  testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java a4a789b579305d9ed573d8c1fd0b6ce75787d50f

  testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java b97b890dfe855539de2696788327ba9b4a841ff3



Diff: https://reviews.apache.org/r/59629/diff/2/

Changes: https://reviews.apache.org/r/59629/diff/1-2/


Testing
-------

Added unit tests for PTestClient and JiraService.
Ran a test with a heavily dumbed down CloudExecutionContextProvider that would create the
drowns on the local machine isntead of a cloud povider to test integration between PTestClient
and the WebService.


Thanks,

Barna Zsombor Klara


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message