hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anthony Hsu via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 59885: HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used
Date Wed, 07 Jun 2017 20:45:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59885/#review177222
-----------------------------------------------------------




metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Line 302 (original), 304 (patched)
<https://reviews.apache.org/r/59885/#comment250766>

    Do we need to close the PersistenceManager as well?


- Anthony Hsu


On 六月 7, 2017, 4:29 p.m., Sunitha Beeram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59885/
> -----------------------------------------------------------
> 
> (Updated 六月 7, 2017, 4:29 p.m.)
> 
> 
> Review request for hive, Carl Steinbach, Anthony Hsu, and Ratandeep Ratti.
> 
> 
> Bugs: HIVE-16844
>     https://issues.apache.org/jira/browse/HIVE-16844
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used
> 
> 
> Diffs
> -----
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 4676e15942d72b0db56bedf0ff30aa60964c28d8

> 
> 
> Diff: https://reviews.apache.org/r/59885/diff/1/
> 
> 
> Testing
> -------
> 
> Can't provide unit tests to test the functionality, but problem is reproducible and one
way to simulate it is by setting pmf=null in ObjectStore::setConf - you will notice leaked
connections. With the fix the same does not happen.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message