Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2712A200C82 for ; Sat, 27 May 2017 18:41:55 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 25990160BD7; Sat, 27 May 2017 16:41:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 697D9160BB8 for ; Sat, 27 May 2017 18:41:54 +0200 (CEST) Received: (qmail 23552 invoked by uid 500); 27 May 2017 16:41:53 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 23525 invoked by uid 99); 27 May 2017 16:41:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 May 2017 16:41:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 92307C1AD0; Sat, 27 May 2017 16:41:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id wI5bMUXuZZxf; Sat, 27 May 2017 16:41:51 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3A3B25F613; Sat, 27 May 2017 16:41:51 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A735FE0012; Sat, 27 May 2017 16:41:50 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 78248C4004B; Sat, 27 May 2017 16:41:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8836458726593267667==" MIME-Version: 1.0 Subject: Re: Review Request 59468: Optimize a combination of avg(), sum(), count(distinct) etc From: Ashutosh Chauhan To: Ashutosh Chauhan , Gopal V Cc: pengcheng xiong , hive Date: Sat, 27 May 2017 16:41:50 -0000 Message-ID: <20170527164150.58630.60635@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Ashutosh Chauhan X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59468/ X-Sender: Ashutosh Chauhan References: <20170527022011.65207.54383@reviews-vm2.apache.org> In-Reply-To: <20170527022011.65207.54383@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/optimizer/CountDistinctRewriteProc.java X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/llap/count_dist_rewrite.q.out X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/count_dist_rewrite.q X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/count_dist_rewrite.q.out Reply-To: Ashutosh Chauhan X-ReviewRequest-Repository: hive-git archived-at: Sat, 27 May 2017 16:41:55 -0000 --===============8836458726593267667== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59468/#review176243 ----------------------------------------------------------- ql/src/test/queries/clientpositive/count_dist_rewrite.q Lines 63-65 (patched) As mentioned previously, lets delete these tests. ql/src/test/results/clientpositive/perf/query16.q.out Lines 3-5 (original), 3-5 (patched) Optimization shouldn't have fired in this case. Aggregations are on different columns. ql/src/test/results/clientpositive/perf/query16.q.out Line 93 (original), 100 (patched) Optimization shouldn't have fired in this case. Aggregations are on different columns. ql/src/test/results/clientpositive/perf/query94.q.out Line 1 (original), 1 (patched) Optimization shouldn't have fired in this case. Aggregations are on columns different than keys. ql/src/test/results/clientpositive/perf/query94.q.out Line 29 (original), 36 (patched) Optimization shouldn't have fired in this case. Aggregations are on columns different than keys. ql/src/test/results/clientpositive/perf/query95.q.out Line 1 (original), 1 (patched) Optimization shouldn't have fired in this case. Aggregations are on columns different than keys. - Ashutosh Chauhan On May 27, 2017, 2:20 a.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59468/ > ----------------------------------------------------------- > > (Updated May 27, 2017, 2:20 a.m.) > > > Review request for hive, Ashutosh Chauhan and Gopal V. > > > Repository: hive-git > > > Description > ------- > > HIVE-16654 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2dfc8b6f89 > itests/src/test/resources/testconfiguration.properties 47a13c93b9 > ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 8b04cd44fa > ql/src/java/org/apache/hadoop/hive/ql/optimizer/CountDistinctRewriteProc.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 7dace9076f > ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 38a9ef2af1 > ql/src/test/queries/clientpositive/count_dist_rewrite.q PRE-CREATION > ql/src/test/results/clientpositive/count_dist_rewrite.q.out PRE-CREATION > ql/src/test/results/clientpositive/groupby_sort_11.q.out 2b3bf4a07a > ql/src/test/results/clientpositive/llap/count_dist_rewrite.q.out PRE-CREATION > ql/src/test/results/clientpositive/nullgroup4.q.out e5a8eeee14 > ql/src/test/results/clientpositive/perf/query16.q.out cf90c0c162 > ql/src/test/results/clientpositive/perf/query28.q.out 78129cf68b > ql/src/test/results/clientpositive/perf/query94.q.out 836b16bf9f > ql/src/test/results/clientpositive/perf/query95.q.out fa94d0842b > ql/src/test/results/clientpositive/udf_count.q.out f60ad0485e > > > Diff: https://reviews.apache.org/r/59468/diff/3/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > > --===============8836458726593267667==--