Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8BC9E200C80 for ; Thu, 25 May 2017 09:21:16 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8A8B7160BCA; Thu, 25 May 2017 07:21:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D8FE5160BC7 for ; Thu, 25 May 2017 09:21:15 +0200 (CEST) Received: (qmail 67834 invoked by uid 500); 25 May 2017 07:21:14 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 67812 invoked by uid 99); 25 May 2017 07:21:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 May 2017 07:21:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6BD3A190D82; Thu, 25 May 2017 07:21:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 2y9IUxq6OKaJ; Thu, 25 May 2017 07:21:11 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1CD895F249; Thu, 25 May 2017 07:21:11 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BA884E005B; Thu, 25 May 2017 07:21:10 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 77428C4034E; Thu, 25 May 2017 07:21:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4204736216208046813==" MIME-Version: 1.0 Subject: Review Request 59569: HIVE-15300: Reuse table information in SemanticAnalyzer::getMetaData to reduce compilation time From: Rajesh Balamohan To: Ashutosh Chauhan , =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= , Pengcheng Xu Cc: hive , Rajesh Balamohan Date: Thu, 25 May 2017 07:21:10 -0000 Message-ID: <20170525072110.61834.75249@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Rajesh Balamohan X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59569/ X-Sender: Rajesh Balamohan Reply-To: Rajesh Balamohan X-ReviewRequest-Repository: hive-git archived-at: Thu, 25 May 2017 07:21:16 -0000 --===============4204736216208046813== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59569/ ----------------------------------------------------------- Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and Pengcheng Xu. Repository: hive-git Description ------- Queries like Q14, Q88 etc do a lot of table lookups in SemanticAnalyzer for the same set of tables. Every lookup costs couple of DB calls. We already have "tabNameToTabObject" which caches table name to Table. This patch attempts to reduce these lookup calls by using information available in the cache. It makes a deep copy after getting the item from cache, so that even any modification downstream does not cause issues. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 43a61ce Diff: https://reviews.apache.org/r/59569/diff/1/ Testing ------- Jenkins passed. TestCliDriver.testCliDriver[index_serde] failure is not related to this patch, it passed in local environment. Thanks, Rajesh Balamohan --===============4204736216208046813==--