Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============1734771032669297061=="
MIME-Version: 1.0
Subject: Re: Review Request 59205: HIVE-16579: CachedStore: improvements to
 partition
 col stats caching and cache column stats for unpartitioned table
From: Thejas Nair <thejas@hortonworks.com>
To: Thejas Nair <thejas@hortonworks.com>, Daniel Dai <daijyc@gmail.com>
Cc: Vaibhav Gumashta <vgumashta@hortonworks.com>, hive <dev@hive.apache.org>
Date: Mon, 15 May 2017 08:19:31 -0000
Message-ID: <20170515081931.55748.90715@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Thejas Nair <noreply@reviews.apache.org>
References: <20170515075922.55748.66093@reviews-vm2.apache.org>
In-Reply-To: <20170515075922.55748.66093@reviews-vm2.apache.org>
Reply-To: Thejas Nair <thejas@hortonworks.com>
archived-at: Mon, 15 May 2017 08:19:42 -0000

--===============1734771032669297061==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59205/#review174936
-----------------------------------------------------------


metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
Line 281 (original), 284 (patched)
<https://reviews.apache.org/r/59205/#comment248225>

    This needs to be TimeUnit.MILLISECONDS, as you want it converted to MILLISECONDS


metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
Line 512 (original), 526 (patched)
<https://reviews.apache.org/r/59205/#comment248226>

    isDatabaseCacheDirty.set(true); - this needs to be set after obtaining the lock
    
    Otherwise, you can have case where it gets reset by background thread before actual update.
    
    (Same with this call in other places)


- Thejas Nair


On May 15, 2017, 7:59 a.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59205/
> -----------------------------------------------------------
> 
> (Updated May 15, 2017, 7:59 a.m.)
> 
> 
> Review request for hive, Daniel Dai and Thejas Nair.
> 
> 
> Bugs: HIVE-16579
>     https://issues.apache.org/jira/browse/HIVE-16579
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-16579
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d6a80ae 
>   itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 91a3a38 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java b897ffa 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java b96c27e 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 870896c 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ed19f42 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java c1af690 
>   metastore/src/java/org/apache/hadoop/hive/metastore/cache/CacheUtils.java 668499b 
>   metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 5a187d8 
>   metastore/src/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java 7beee42 
>   metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 0c7d8bb 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java f613c30 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 1720e37 
>   metastore/src/test/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java 0ab20d6 
> 
> 
> Diff: https://reviews.apache.org/r/59205/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


--===============1734771032669297061==--