Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8A5DC200C79 for ; Fri, 5 May 2017 04:49:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 88EC4160BC4; Fri, 5 May 2017 02:49:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CF671160BB0 for ; Fri, 5 May 2017 04:49:57 +0200 (CEST) Received: (qmail 52265 invoked by uid 500); 5 May 2017 02:49:56 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 52254 invoked by uid 99); 5 May 2017 02:49:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 May 2017 02:49:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 31813C34C3; Fri, 5 May 2017 02:49:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ERkG0DlfVZvH; Fri, 5 May 2017 02:49:55 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6728A5F5CA; Fri, 5 May 2017 02:49:54 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B152EE008E; Fri, 5 May 2017 02:49:53 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 9FD5BC40644; Fri, 5 May 2017 02:49:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0437575731286182977==" MIME-Version: 1.0 Subject: Re: Review Request 58934: HIVE-16568: Support complex types in external LLAP InputFormat From: Jason Dere To: Gunther Hagleitner , j.prasanth.j@gmail.com, Siddharth Seth Cc: hive , Jason Dere Date: Fri, 05 May 2017 02:49:53 -0000 Message-ID: <20170505024953.33377.81983@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jason Dere X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58934/ X-Sender: Jason Dere References: <20170502215240.39149.82201@reviews-vm2.apache.org> In-Reply-To: <20170502215240.39149.82201@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: llap-common/src/java/org/apache/hadoop/hive/llap/TypeDesc.java Reply-To: Jason Dere X-ReviewRequest-Repository: hive-git archived-at: Fri, 05 May 2017 02:49:58 -0000 --===============0437575731286182977== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58934/ ----------------------------------------------------------- (Updated May 5, 2017, 2:49 a.m.) Review request for hive, Gunther Hagleitner, Prasanth_J, and Siddharth Seth. Changes ------- Use TypeInfo rather than TypeDesc. Remove TypeDesc class. Bugs: HIVE-16568 https://issues.apache.org/jira/browse/HIVE-16568 Repository: hive-git Description ------- - Support list/map/struct types in the LLAPRowInputFormat Schema/TypeDesc - Support list/map/struct types in the LLAPRowInputFormat Row. Changes in the Row getters/setters needed (no longer using Writable). Diffs (updated) ----- itests/hive-unit/src/test/java/org/apache/hadoop/hive/llap/ext/TestLlapInputSplit.java 654e92b itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniLlap.java de47412 llap-client/src/java/org/apache/hadoop/hive/llap/LlapRowRecordReader.java ee92f3e llap-common/src/java/org/apache/hadoop/hive/llap/FieldDesc.java 9621978 llap-common/src/java/org/apache/hadoop/hive/llap/Row.java a84fadc llap-common/src/java/org/apache/hadoop/hive/llap/TypeDesc.java dda5928 llap-common/src/test/org/apache/hadoop/hive/llap/TestRow.java d4e68f4 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java 9ddbd7e ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java b003eb8 Diff: https://reviews.apache.org/r/58934/diff/2/ Changes: https://reviews.apache.org/r/58934/diff/1-2/ Testing ------- Added test to TestJdbcWithMiniLlap Thanks, Jason Dere --===============0437575731286182977==--