Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============7294604087611139339=="
MIME-Version: 1.0
Subject: Re: Review Request 58914: HIVE-16550
From: Deepak Jaiswal <djaiswal@hortonworks.com>
To: Sergey Shelukhin <sergey@hortonworks.com>,
 Jason Dere <jdere@hortonworks.com>
Cc: Deepak Jaiswal <djaiswal@hortonworks.com>, hive <dev@hive.apache.org>,
 Vineet Garg <vgarg@hortonworks.com>
Date: Tue, 02 May 2017 18:59:03 -0000
Message-ID: <20170502185903.39149.86347@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Deepak Jaiswal <noreply@reviews.apache.org>
References: <20170502183520.39150.21998@reviews-vm2.apache.org>
In-Reply-To: <20170502183520.39150.21998@reviews-vm2.apache.org>
Reply-To: Deepak Jaiswal <djaiswal@hortonworks.com>
archived-at: Tue, 02 May 2017 18:59:07 -0000

--===============7294604087611139339==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On May 2, 2017, 6:35 p.m., Vineet Garg wrote:
> > ql/src/test/queries/clientpositive/semijoin_hint.q
> > Line 38 (original), 38 (patched)
> > <https://reviews.apache.org/r/58914/diff/1/?file=1705394#file1705394line38>
> >
> >     Why is returnpath on?
> >     This feature is not yet fully developed/supported and is off by default. 
> >     You might want to try the same queries with this feature off.
> 
> Deepak Jaiswal wrote:
>     We have to make sure we dont break it.
>     There are tests below with the feature turned off.
> 
> Vineet Garg wrote:
>     Ok in that case can you add the same tests with returnpath off? I don't see union all query with returnpath off

sure.


- Deepak


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58914/#review173558
-----------------------------------------------------------


On May 2, 2017, 5:47 a.m., Deepak Jaiswal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58914/
> -----------------------------------------------------------
> 
> (Updated May 2, 2017, 5:47 a.m.)
> 
> 
> Review request for hive, Jason Dere and Sergey Shelukhin.
> 
> 
> Bugs: HIVE-16550
>     https://issues.apache.org/jira/browse/HIVE-16550
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Semijoin Hints should be able to skip the optimization if needed.
> In addition to that, the patch fixes several issues with hints in general such as,
> - It now works with subqueries and unions.
> - Uses a global data structure instead of per QB.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java e1a69526bc 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java d375d1b58d 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 1b054a7e24 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HintParser.g e110fb33df 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 3a1f821bd3 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 54e37f7c80 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 7bf1c599a5 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 654f3b1772 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 5ea7800528 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDynamicListDesc.java 3143554ec6 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 032c7bb28d 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java f45daa8828 
>   ql/src/test/queries/clientpositive/semijoin_hint.q 5de0c8c8c1 
>   ql/src/test/results/clientpositive/llap/semijoin_hint.q.out bc248930ec 
> 
> 
> Diff: https://reviews.apache.org/r/58914/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Deepak Jaiswal
> 
>


--===============7294604087611139339==--