hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <pv...@cloudera.com>
Subject Re: Review Request 59402: HIVE-16718: Provide a way to pass in user supplied maven build and test arguments to Ptest
Date Sat, 20 May 2017 07:03:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59402/#review175590
-----------------------------------------------------------


Ship it!




Thanks for the patch Zsombor!
+1 LGTM(non-binding)

- Peter Vary


On máj. 19, 2017, 3:10 du, Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59402/
> -----------------------------------------------------------
> 
> (Updated máj. 19, 2017, 3:10 du)
> 
> 
> Review request for hive, Sergio Pena and Sahil Takiar.
> 
> 
> Bugs: HIVE-16718
>     https://issues.apache.org/jira/browse/HIVE-16718
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16718: Provide a way to pass in user supplied maven build and test arguments to
Ptest
> 
> 
> Diffs
> -----
> 
>   testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60

>   testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
e584f9c105fa134e3e267d6c6817d441b4c6b249 
> 
> 
> Diff: https://reviews.apache.org/r/59402/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually that I can pass in 0, 1 or 2 arguments to both mvnBuildArgs and mvnTestArgs
in PTest.
> Arguments will be key value pairs separated by '='. The '-D' will be added automatically.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message