hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Shelukhin <ser...@hortonworks.com>
Subject Re: Review Request 59325: Cleanup of structures required when LLAP access from external clients completes
Date Wed, 17 May 2017 02:02:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59325/#review175184
-----------------------------------------------------------




llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java
Lines 192 (patched)
<https://reviews.apache.org/r/59325/#comment248574>

    external tasks cannot use shuffle? just checking



llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java
Lines 464 (patched)
<https://reviews.apache.org/r/59325/#comment248582>

    will there be a callable created after every single fragment that finishes for the query
with no other fragments running? Perhaps one callable should wait for the entire query and
the fragments coming it should just push back the timestamp at which the query would time
out and be cleaned?
    
    also what if readLock blocks all cleanup attempts?


- Sergey Shelukhin


On May 17, 2017, 12:30 a.m., Siddharth Seth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59325/
> -----------------------------------------------------------
> 
> (Updated May 17, 2017, 12:30 a.m.)
> 
> 
> Review request for hive, Jason Dere and Sergey Shelukhin.
> 
> 
> Bugs: HIVE-14052
>     https://issues.apache.org/jira/browse/HIVE-14052
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Cleanup of structures required when LLAP access from external clients completes
> 
> 
> Diffs
> -----
> 
>   llap-common/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/daemon/rpc/LlapDaemonProtocolProtos.java
ece31ed 
>   llap-common/src/protobuf/LlapDaemonProtocol.proto 3a3a2b8 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java ce2f457

>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java daeb555

>   llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java
27c426c 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java 868eec7

> 
> 
> Diff: https://reviews.apache.org/r/59325/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Siddharth Seth
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message