hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lefty Leverenz <leftylever...@gmail.com>
Subject Re: Review Request 58865: HIVE-16552: Limit the number of tasks a Spark job may contain
Date Thu, 04 May 2017 06:44:47 GMT


> On April 30, 2017, 4:15 a.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> > Lines 3340-3341 (patched)
> > <https://reviews.apache.org/r/58865/diff/1/?file=1703679#file1703679line3340>
> >
> >     "... more tasks than the maximu, ..." -> maximum
> >     
> >     Also, please add one or more newlines (\n) so the generated file hive-default.xml.template
won't put the entire parameter description on a single line.

+1  Looks good now, thanks.


- Lefty


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58865/#review173436
-----------------------------------------------------------


On May 3, 2017, 6:14 p.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58865/
> -----------------------------------------------------------
> 
> (Updated May 3, 2017, 6:14 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-16552
>     https://issues.apache.org/jira/browse/HIVE-16552
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See JIRA description
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 84398c6 
>   itests/src/test/resources/testconfiguration.properties 753f3a9 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java 32a7730 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RemoteSparkJobMonitor.java
dd73f3e 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java 0b224f2

>   ql/src/test/queries/clientnegative/spark_job_max_tasks.q PRE-CREATION 
>   ql/src/test/results/clientnegative/spark/spark_job_max_tasks.q.out PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58865/diff/4/
> 
> 
> Testing
> -------
> 
> Test locally
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message