Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 61102200C76 for ; Sat, 29 Apr 2017 05:35:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5F946160BB8; Sat, 29 Apr 2017 03:35:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CB8FE160BA3 for ; Sat, 29 Apr 2017 05:35:27 +0200 (CEST) Received: (qmail 90618 invoked by uid 500); 29 Apr 2017 03:35:26 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 90603 invoked by uid 99); 29 Apr 2017 03:35:26 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Apr 2017 03:35:26 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4176FE0061; Sat, 29 Apr 2017 03:35:26 +0000 (UTC) From: lys0716 To: dev@hive.apache.org Reply-To: dev@hive.apache.org Message-ID: Subject: [GitHub] hive pull request #174: Add EOF for the first rule in Hplsql.g4 Content-Type: text/plain Date: Sat, 29 Apr 2017 03:35:26 +0000 (UTC) archived-at: Sat, 29 Apr 2017 03:35:28 -0000 GitHub user lys0716 opened a pull request: https://github.com/apache/hive/pull/174 Add EOF for the first rule in Hplsql.g4 According to https://github.com/antlr/antlr4/issues/118, it is better to add EOF for the first rule in grammar. This can solve the potential incorrect error message. Signed-off-by: Yishuang Lu You can merge this pull request into a Git repository by running: $ git pull https://github.com/lys0716/hive master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hive/pull/174.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #174 ---- commit adc2d019d25fd83aedaaa5b4836430819a9de1ae Author: lys0716 Date: 2017-04-29T03:33:48Z Add EOF for the first rule in Hplsql.g4 According to https://github.com/antlr/antlr4/issues/118, it is better to add EOF for the first rule in grammar. This can solve the potential incorrect error message. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---