Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0F67B200C70 for ; Thu, 20 Apr 2017 01:58:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0DEEA160BAA; Wed, 19 Apr 2017 23:58:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 566C9160B9C for ; Thu, 20 Apr 2017 01:58:02 +0200 (CEST) Received: (qmail 50038 invoked by uid 500); 19 Apr 2017 23:58:00 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 50025 invoked by uid 99); 19 Apr 2017 23:58:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Apr 2017 23:58:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E15A81813FA; Wed, 19 Apr 2017 23:57:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.5 X-Spam-Level: *** X-Spam-Status: No, score=3.5 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id LSV2Poy22JR2; Wed, 19 Apr 2017 23:57:58 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2FB135F2FD; Wed, 19 Apr 2017 23:57:58 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C207BE0436; Wed, 19 Apr 2017 23:57:57 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 972A8C400B0; Wed, 19 Apr 2017 23:57:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0607087055103358440==" MIME-Version: 1.0 Subject: Re: Review Request 58390: HIVE-16423 From: Deepak Jaiswal To: Sergey Shelukhin , Jason Dere Cc: Deepak Jaiswal , hive Date: Wed, 19 Apr 2017 23:57:57 -0000 Message-ID: <20170419235757.26674.48928@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Deepak Jaiswal X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58390/ X-Sender: Deepak Jaiswal References: <20170413211853.5223.29078@reviews-vm2.apache.org> In-Reply-To: <20170413211853.5223.29078@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/llap/semijoin_hint.q.out X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/semijoin_hint.q X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/parse/SemiJoinHint.java X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/parse/SemiJoinBranchInfo.java Reply-To: Deepak Jaiswal X-ReviewRequest-Repository: hive-git archived-at: Wed, 19 Apr 2017 23:58:03 -0000 --===============0607087055103358440== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58390/ ----------------------------------------------------------- (Updated April 19, 2017, 11:57 p.m.) Review request for hive, Jason Dere and Sergey Shelukhin. Changes ------- Applied review comments and added some more tests. Bugs: HIVE-16423 https://issues.apache.org/jira/browse/HIVE-16423 Repository: hive-git Description ------- De-duplicate semijoin branches and add hint to enforce semi join optimization Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 420d35eb42 itests/src/test/resources/testconfiguration.properties ed5ce9d384 ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java db6b05b7ac ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java 838cc69cb6 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 73a9b0f34d ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 67ea05d7b1 ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java d58f4474b6 ql/src/java/org/apache/hadoop/hive/ql/parse/HintParser.g 8e70a46235 ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 3f9f76c57f ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java ec76fb79c5 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77fc35d36d ql/src/java/org/apache/hadoop/hive/ql/parse/SemiJoinBranchInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/parse/SemiJoinHint.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 7caeb78e44 ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java eaad988fc5 ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDynamicListDesc.java 18e4fbdc0a ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java bcf3691342 ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 71c731081f ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBloomFilter.java 2b84beb100 ql/src/test/queries/clientpositive/semijoin_hint.q PRE-CREATION ql/src/test/results/clientpositive/llap/semijoin_hint.q.out PRE-CREATION Diff: https://reviews.apache.org/r/58390/diff/3/ Changes: https://reviews.apache.org/r/58390/diff/2-3/ Testing ------- Thanks, Deepak Jaiswal --===============0607087055103358440==--