Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E77A6200C53 for ; Tue, 11 Apr 2017 23:10:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E6155160B7D; Tue, 11 Apr 2017 21:10:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 13AB8160B9B for ; Tue, 11 Apr 2017 23:10:48 +0200 (CEST) Received: (qmail 62237 invoked by uid 500); 11 Apr 2017 21:10:48 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 61910 invoked by uid 99); 11 Apr 2017 21:10:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Apr 2017 21:10:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 76EDBC144D; Tue, 11 Apr 2017 21:10:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id VJFVgy1-1o3A; Tue, 11 Apr 2017 21:10:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C91815FCD2; Tue, 11 Apr 2017 21:10:44 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0C89FE0D3C; Tue, 11 Apr 2017 21:10:44 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id BCCB2C402CA; Tue, 11 Apr 2017 21:10:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6248821951273902089==" MIME-Version: 1.0 Subject: Re: Review Request 57893: HIVE-16285: Servlet for dynamically configuring log levels From: j.prasanth.j@gmail.com To: Gopal V , Siddharth Seth Cc: hive , j.prasanth.j@gmail.com Date: Tue, 11 Apr 2017 21:10:43 -0000 Message-ID: <20170411211043.22151.97041@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: noreply@reviews.apache.org X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57893/ X-Sender: noreply@reviews.apache.org References: <20170404223813.22167.41594@reviews-vm2.apache.org> In-Reply-To: <20170404223813.22167.41594@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: common/src/java/org/apache/hive/http/Log4j2ConfiguratorServlet.java Reply-To: j.prasanth.j@gmail.com X-ReviewRequest-Repository: hive-git archived-at: Tue, 11 Apr 2017 21:10:50 -0000 --===============6248821951273902089== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57893/ ----------------------------------------------------------- (Updated April 11, 2017, 9:10 p.m.) Review request for hive, Gopal V and Siddharth Seth. Changes ------- Addressed Gopal's review comments. Bugs: HIVE-16285 https://issues.apache.org/jira/browse/HIVE-16285 Repository: hive-git Description ------- Many long running services like HS2, LLAP etc. will benefit from having an endpoint to dynamically change log levels for various loggers. This will help greatly with debuggability without requiring a restart of the service. Diffs (updated) ----- common/src/java/org/apache/hive/http/HttpServer.java fd3d457 common/src/java/org/apache/hive/http/Log4j2ConfiguratorServlet.java PRE-CREATION llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java 7f8c947 llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java 18ce03c ql/src/java/org/apache/hadoop/hive/ql/exec/AppMasterEventOperator.java bf30ef1 ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java df1898e ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java c184742 ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 4d727ba ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 6d6c608 ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java 3a366f6 ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java 0282763 ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 07aa2ea ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 2a46b30 ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java 9849243 ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 8b04cd4 ql/src/java/org/apache/hadoop/hive/ql/exec/OrcFileMergeOperator.java e3cb765 ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java e03f4b7 ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 7c1e344 ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 4767af1 ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 94af097 ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 68477ca ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 3df5533 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java 1dffff2 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ObjectCache.java cfe1750 ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ColumnarSplitSizeEstimator.java ecd4ddc ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HostAffinitySplitLocationProvider.java dcb985f ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapObjectCache.java 1ce8ee9 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinCommonOperator.java f854132 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinGenerateResultOperator.java cb30413 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyLongOperator.java 43f3951 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyMultiKeyOperator.java 95fb0c2 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyStringOperator.java 044e3e6 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerLongOperator.java c85e1d8 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerMultiKeyOperator.java a108cd0 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerStringOperator.java 3211d7d ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiLongOperator.java b02e6fd ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiMultiKeyOperator.java 36b8f3f ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiStringOperator.java 0b3de0a ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterGenerateResultOperator.java 0e2d65a ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterLongOperator.java 72309e8 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterMultiKeyOperator.java a4fc7d3 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterStringOperator.java 6e7e5cb ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashTable.java b93e977 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashTable.java 8bfa07c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java fc5aea5 ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java 9299306 ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 8fb7211 ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 6844713 serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java aa19d09 Diff: https://reviews.apache.org/r/57893/diff/4/ Changes: https://reviews.apache.org/r/57893/diff/3-4/ Testing ------- Thanks, Prasanth_J --===============6248821951273902089==--