Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============2690165069138452518=="
MIME-Version: 1.0
Subject: Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct
 from'
From: Vineet Garg <vgarg@hortonworks.com>
To: Ashutosh Chauhan <hashutosh@apache.org>,
 =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?=
 <jcamachorodriguez@hortonworks.com>, Pengcheng Xu <pengchexuacnt@gmail.com>
Cc: pengcheng xiong <pxiong@hortonworks.com>, hive <dev@hive.apache.org>,
 Vineet Garg <vgarg@hortonworks.com>
Date: Thu, 06 Apr 2017 20:36:55 -0000
Message-ID: <20170406203655.2051.32912@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Vineet Garg <noreply@reviews.apache.org>
References: <20170406201838.2051.48227@reviews-vm2.apache.org>
In-Reply-To: <20170406201838.2051.48227@reviews-vm2.apache.org>
Reply-To: Vineet Garg <vgarg@hortonworks.com>
archived-at: Thu, 06 Apr 2017 20:36:59 -0000

--===============2690165069138452518==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


> On April 6, 2017, 8:18 p.m., pengcheng xiong wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g
> > Line 590 (original), 597 (patched)
> > <https://reviews.apache.org/r/58181/diff/4/?file=1685826#file1685826line597>
> >
> >     Can you also confirm the precedence of is distinct with other operators? Now, it is the same precedence as equal. try 1 is not distinct from 2 is not distinct from false, etc.

As you have already noted precedence of 'is distinct from' is same as '='.


> On April 6, 2017, 8:18 p.m., pengcheng xiong wrote:
> > ql/src/test/queries/clientpositive/is_distinct_from.q
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/58181/diff/4/?file=1685828#file1685828line1>
> >
> >     Can we compare a column with a constant in is distinct from? or two columns? Or it should be limited to compare constants only?

Yes it is not only limited to constant,you can compare columns as well.


- Vineet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58181/#review171246
-----------------------------------------------------------


On April 6, 2017, 8:02 p.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58181/
> -----------------------------------------------------------
> 
> (Updated April 6, 2017, 8:02 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and Pengcheng Xu.
> 
> 
> Bugs: HIVE-15986
>     https://issues.apache.org/jira/browse/HIVE-15986
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This patch adds support for 'is distinct from' and 'is not distinct from'.
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties 7a70c9c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java ccfb455 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java 85450c9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g d98a663 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 8c4ee8a 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java f979c14 
>   ql/src/test/queries/clientpositive/is_distinct_from.q PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/is_distinct_from.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/show_functions.q.out 68e248a 
>   ql/src/test/results/clientpositive/udf_equal.q.out 52bd843 
> 
> 
> Diff: https://reviews.apache.org/r/58181/diff/4/
> 
> 
> Testing
> -------
> 
> Added new tests
> Pre-commit testing
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>


--===============2690165069138452518==--