Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============7050774886154699641=="
MIME-Version: 1.0
Subject: Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct
 from'
From: Ashutosh Chauhan <hashutosh@apache.org>
To: Ashutosh Chauhan <hashutosh@apache.org>,
 =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?=
 <jcamachorodriguez@hortonworks.com>
Cc: hive <dev@hive.apache.org>, Vineet Garg <vgarg@hortonworks.com>
Date: Wed, 05 Apr 2017 15:37:48 -0000
Message-ID: <20170405153748.56252.46552@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Ashutosh Chauhan <noreply@reviews.apache.org>
References: <20170404230522.22168.83818@reviews-vm2.apache.org>
In-Reply-To: <20170404230522.22168.83818@reviews-vm2.apache.org>
Reply-To: Ashutosh Chauhan <hashutosh@apache.org>
archived-at: Wed, 05 Apr 2017 15:37:53 -0000

--===============7050774886154699641==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58181/#review171125
-----------------------------------------------------------


ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g
Lines 590-592 (patched)
<https://reviews.apache.org/r/58181/#comment244016>

    It will be good to not add extra tokens in grammar as it increases the size of state machine. How about:
    
        KW_IS (a=KW_NOT)? KW_DISTINCT KW_FROM
        -> {$a !=null}? ^(EQUAL_NS)
        -> ^(KW_NOT EQUAL_NS)


- Ashutosh Chauhan


On April 4, 2017, 11:05 p.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58181/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 11:05 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.
> 
> 
> Bugs: HIVE-15986
>     https://issues.apache.org/jira/browse/HIVE-15986
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This patch adds support for 'is distinct from' and 'is not distinct from'.
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties 7a70c9c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java ccfb455 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java 85450c9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g d98a663 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 8c4ee8a 
>   ql/src/test/queries/clientpositive/is_distinct_from.q PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/is_distinct_from.q.out PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58181/diff/2/
> 
> 
> Testing
> -------
> 
> Added new tests
> Pre-commit testing
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>


--===============7050774886154699641==--