hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chaoyu Tang <>
Subject Re: Review Request 58686: HIVE-16147: Rename a partitioned table should not drop its partition columns stats
Date Fri, 28 Apr 2017 18:19:16 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 28, 2017, 6:19 p.m.)

Review request for hive and pengcheng xiong.


Furhter changes to fix the test failures:
1. partititon view does not have SD, so we need check if SD is null or not before further
calling its getCols()
2. ObjectStore.getMPartitionColumnStatistics validated the partition columns against Table
which I thought is not correct. Partition might have a different column definition from Table.
In this case, we should raise some warning instead of throwing out the exception.

Bugs: HIVE-16147

Repository: hive-git


The patch is to
1. preserve the column stats after a partitioned table is renamed
2. rename the alter_table_invalidate_column_stats.q to alter_table_column_stats.q

Diffs (updated)

  metastore/src/java/org/apache/hadoop/hive/metastore/ 77b3541 
  metastore/src/java/org/apache/hadoop/hive/metastore/ 1b701e0 
  metastore/src/java/org/apache/hadoop/hive/metastore/ 6b21751 
  ql/src/test/queries/clientpositive/alter_table_column_stats.q PRE-CREATION 
  ql/src/test/queries/clientpositive/alter_table_invalidate_column_stats.q a478451 
  ql/src/test/results/clientpositive/alter_table_column_stats.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/alter_table_invalidate_column_stats.q.out 85d7dc4 




manual tests


Chaoyu Tang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message