hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vihang Karajgaonkar <vih...@cloudera.com>
Subject Re: Review Request 58516: HIVE-16213 : ObjectStore can leak Queries when rollbackTransaction throws an exception
Date Fri, 21 Apr 2017 17:38:10 GMT


> On April 21, 2017, 6:19 a.m., Alexander Kolbasov wrote:
> > The name is not very good rollbackIfNotSuccessful since this thing also closes query,
but rollbackaIfNotSuccessfulButCloseQueryAnyway isn't much better :-).
> > May be just cleanup()?

I agree with the name not being great. How about I use rollbackAndCleanup() and add a good
javadoc :)


- Vihang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58516/#review172590
-----------------------------------------------------------


On April 20, 2017, 10:01 p.m., Vihang Karajgaonkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58516/
> -----------------------------------------------------------
> 
> (Updated April 20, 2017, 10:01 p.m.)
> 
> 
> Review request for hive, Alexander Kolbasov, Sergio Pena, and Sahil Takiar.
> 
> 
> Bugs: HIVE-16213
>     https://issues.apache.org/jira/browse/HIVE-16213
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16213 : ObjectStore can leak Queries when rollbackTransaction throws an exception
> 
> 
> Diffs
> -----
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 6b217516bc74c612348b8edeca077dfbdbdb1a40

>   metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 9b8eaf2ab72fcf1fe0d58e8913ac1b84ec7e71cf

> 
> 
> Diff: https://reviews.apache.org/r/58516/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vihang Karajgaonkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message