hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dere <jd...@hortonworks.com>
Subject Re: Review Request 58585: HIVE-16441
Date Thu, 20 Apr 2017 21:52:39 GMT


> On April 20, 2017, 9:39 p.m., Jason Dere wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java
> > Line 829 (original)
> > <https://reviews.apache.org/r/58585/diff/1/?file=1695646#file1695646line829>
> >
> >     Just a nit, but why was removeSemiJoin removed? Seems like we are now duplicating
the logic to remove the semijoin.

Deepak has pointed out that in the maxEntries/no stats case, all of the semijoins for that
particular column expression should be removed, whereas if check fails due to TEZ_BIGTABLE_MIN_SIZE_SEMIJOIN_REDUCTION,
only the particular semijoin going to that destination should be removed.


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58585/#review172548
-----------------------------------------------------------


On April 20, 2017, 6:20 p.m., Deepak Jaiswal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58585/
> -----------------------------------------------------------
> 
> (Updated April 20, 2017, 6:20 p.m.)
> 
> 
> Review request for hive, Jason Dere and Prasanth_J.
> 
> 
> Bugs: HIVE-16441
>     https://issues.apache.org/jira/browse/HIVE-16441
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> De-duplicate semijoin branches in n-way joins
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java
eb3eba536c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 9a69f90483 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 96525b4b66 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 26eda0461f 
>   ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out a47ce6e583

> 
> 
> Diff: https://reviews.apache.org/r/58585/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Deepak Jaiswal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message