hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dere <jd...@hortonworks.com>
Subject Re: Review Request 58390: HIVE-16423
Date Thu, 20 Apr 2017 00:06:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58390/#review172432
-----------------------------------------------------------




ql/src/test/results/clientpositive/llap/semijoin_hint.q.out
Lines 504 (patched)
<https://reviews.apache.org/r/58390/#comment245549>

    The expectedEntries value does not match the value from the hint. I think you need to
update the final aggregator with the hint value as well.


- Jason Dere


On April 19, 2017, 11:57 p.m., Deepak Jaiswal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58390/
> -----------------------------------------------------------
> 
> (Updated April 19, 2017, 11:57 p.m.)
> 
> 
> Review request for hive, Jason Dere and Sergey Shelukhin.
> 
> 
> Bugs: HIVE-16423
>     https://issues.apache.org/jira/browse/HIVE-16423
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> De-duplicate semijoin branches and add hint to enforce semi join optimization
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 420d35eb42 
>   itests/src/test/resources/testconfiguration.properties ed5ce9d384 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java db6b05b7ac

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java
838cc69cb6 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java
73a9b0f34d 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 67ea05d7b1 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java d58f4474b6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HintParser.g 8e70a46235 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 3f9f76c57f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java ec76fb79c5 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77fc35d36d 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemiJoinBranchInfo.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemiJoinHint.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 7caeb78e44 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java eaad988fc5 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDynamicListDesc.java 18e4fbdc0a

>   ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java bcf3691342 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 71c731081f 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBloomFilter.java 2b84beb100

>   ql/src/test/queries/clientpositive/semijoin_hint.q PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/semijoin_hint.q.out PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58390/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Deepak Jaiswal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message