hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sahil Takiar <takiar.sa...@gmail.com>
Subject Re: Review Request 58516: HIVE-16213 : ObjectStore can leak Queries when rollbackTransaction throws an exception
Date Tue, 18 Apr 2017 21:12:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58516/#review172268
-----------------------------------------------------------


Ship it!




LGTM. It would be nice to add a unit test to one of the `ObjectStore` methods, say `getMDatabase`,
to check that if `rollbackTransation` throws an exception then `query.closeAll` is invoked.

- Sahil Takiar


On April 18, 2017, 7:15 p.m., Vihang Karajgaonkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58516/
> -----------------------------------------------------------
> 
> (Updated April 18, 2017, 7:15 p.m.)
> 
> 
> Review request for hive, Alexander Kolbasov, Sergio Pena, and Sahil Takiar.
> 
> 
> Bugs: HIVE-16213
>     https://issues.apache.org/jira/browse/HIVE-16213
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16213 : ObjectStore can leak Queries when rollbackTransaction throws an exception
> 
> 
> Diffs
> -----
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 6b217516bc74c612348b8edeca077dfbdbdb1a40

> 
> 
> Diff: https://reviews.apache.org/r/58516/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vihang Karajgaonkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message