hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <pv...@cloudera.com>
Subject Re: Review Request 58454: HIVE-16449 BeeLineDriver should handle query result sorting
Date Fri, 14 Apr 2017 15:02:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58454/
-----------------------------------------------------------

(Updated April 14, 2017, 3:02 p.m.)


Review request for hive, Zoltan Haindrich, Vihang Karajgaonkar, and Yongzhi Chen.


Changes
-------

Added null check, so other tests will not fail


Bugs: HIVE-16449
    https://issues.apache.org/jira/browse/HIVE-16449


Repository: hive-git


Description
-------

Changes to support the following features in the BeeLine Qtests:
– SORT_QUERY_RESULTS
– HASH_QUERY_RESULTS
– SORT_AND_HASH_QUERY_RESULTS

The patch contains the following changes:
- Added the possibility to the OutputFile to add the existing FetchConverters
- Indicate the start and the end of the result fetching when fetching the resultset
- Parsed the query files for indentifing the cases when the converters are needed


Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/Commands.java d179b37 
  beeline/src/java/org/apache/hive/beeline/OutputFile.java 1014af3 
  itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java 8c7057c

  itests/util/src/main/java/org/apache/hive/beeline/qfile/QFile.java 9fae194 
  itests/util/src/main/java/org/apache/hive/beeline/qfile/QFileBeeLineClient.java 7244bf8

  itests/util/src/main/java/org/apache/hive/beeline/qfile/package-info.java  
  ql/src/test/results/clientpositive/beeline/smb_mapjoin_1.q.out 70a37ca 
  ql/src/test/results/clientpositive/beeline/smb_mapjoin_2.q.out 22a2d6a 
  ql/src/test/results/clientpositive/beeline/smb_mapjoin_3.q.out 6c9b8e4 


Diff: https://reviews.apache.org/r/58454/diff/3/

Changes: https://reviews.apache.org/r/58454/diff/2-3/


Testing
-------

Checked the output changes of the existing BeeLineDriver tests


Thanks,

Peter Vary


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message