hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <>
Subject Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper
Date Wed, 05 Apr 2017 17:21:01 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 5, 2017, 5:21 p.m.)

Review request for hive, Aihua Xu, Chaoyu Tang, Marta Kuczora, Miklos Csanady, and Barna Zsombor


Changed default value from -1 to Integer.MAX_VALUE as suggested by Vihang.
Added extra test cases for edge cases

Bugs: HIVE-16334

Repository: hive-git


The patch contains the following changes:
- Added a new config variable which defines the maximum length of the query string in the
lock object
- When constructing the HiveLockObject gets the configuration as a new parameter
- When constructing the HiveLockObject truncates the length of the query string if it is necessary
- Updates every occurance of the HiveLockObject creation

Diffs (updated)

  common/src/java/org/apache/hadoop/hive/conf/ 6de6ed6 
  ql/src/java/org/apache/hadoop/hive/ql/lockmgr/ 53ee9c8 
  ql/src/java/org/apache/hadoop/hive/ql/lockmgr/ fff03df 
  ql/src/java/org/apache/hadoop/hive/ql/lockmgr/ a371a5a 
  ql/src/test/org/apache/hadoop/hive/ql/lockmgr/ de3b8ad 
  ql/src/test/org/apache/hadoop/hive/ql/lockmgr/ 0afbc1c 
  ql/src/test/org/apache/hadoop/hive/ql/lockmgr/ 19cb129 
  ql/src/test/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ 3f9926e




Added new unit test to test the truncation
Updated the existing unit tests


Peter Vary

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message