Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BF1E0200C44 for ; Mon, 27 Mar 2017 10:01:13 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BDC81160B85; Mon, 27 Mar 2017 08:01:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0EFC4160B5D for ; Mon, 27 Mar 2017 10:01:12 +0200 (CEST) Received: (qmail 87397 invoked by uid 500); 27 Mar 2017 08:01:12 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 87386 invoked by uid 99); 27 Mar 2017 08:01:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Mar 2017 08:01:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6DDF1C0ABA; Mon, 27 Mar 2017 08:01:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.75 X-Spam-Level: *** X-Spam-Status: No, score=3.75 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id CvNk5xNzVwDD; Mon, 27 Mar 2017 08:01:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0BB115F341; Mon, 27 Mar 2017 08:01:08 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3805BE002F; Mon, 27 Mar 2017 08:01:00 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 09979C4095A; Mon, 27 Mar 2017 08:00:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0285716639584764889==" MIME-Version: 1.0 Subject: Re: Review Request 57728: HIVE-16231: Parquet timestamp may be stored differently since HIVE-12767 From: Barna Zsombor Klara To: Sergio Pena Cc: Barna Zsombor Klara , hive Date: Mon, 27 Mar 2017 08:00:59 -0000 Message-ID: <20170327080059.41782.84748@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Barna Zsombor Klara X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57728/ X-Sender: Barna Zsombor Klara References: <20170324095650.17293.60507@reviews-vm2.apache.org> In-Reply-To: <20170324095650.17293.60507@reviews-vm2.apache.org> Reply-To: Barna Zsombor Klara X-ReviewRequest-Repository: hive-git archived-at: Mon, 27 Mar 2017 08:01:13 -0000 --===============0285716639584764889== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57728/ ----------------------------------------------------------- (Updated March 27, 2017, 8 a.m.) Review request for hive and Sergio Pena. Changes ------- Removed empty line from DateUtils. Repository: hive-git Description ------- HIVE-16231: Parquet timestamp may be stored differently since HIVE-12767 Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/io/parquet/MapredParquetOutputFormat.java 26f1e75c7d659a634cd4eef3a0cb8e886b22722f ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ParquetRecordReaderBase.java 8e33b7d437894b33b35f32913a3bc02f2a849ce3 ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java 5dc808800290f3274afbdff12134ac34387a746b ql/src/test/org/apache/hadoop/hive/ql/io/parquet/timestamp/TestNanoTimeUtils.java 37cf0e2d74589cfa97fa24c9d2d8d00ea62390ee ql/src/test/queries/clientpositive/parquet_int96_timestamp.q 5de2c3f1244b8340b97eb0547fe66e52d80fb065 Diff: https://reviews.apache.org/r/57728/diff/4/ Changes: https://reviews.apache.org/r/57728/diff/3-4/ Testing ------- Tested loading timestamps from a parquet file written by spark. Thanks, Barna Zsombor Klara --===============0285716639584764889==--