Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6B377200C4D for ; Wed, 22 Mar 2017 00:30:12 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 69EC5160B90; Tue, 21 Mar 2017 23:30:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AF8A9160B81 for ; Wed, 22 Mar 2017 00:30:11 +0100 (CET) Received: (qmail 71341 invoked by uid 500); 21 Mar 2017 23:30:10 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 71324 invoked by uid 99); 21 Mar 2017 23:30:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Mar 2017 23:30:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5A8071812FA; Tue, 21 Mar 2017 23:30:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id gM2zZBmZPOUc; Tue, 21 Mar 2017 23:30:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 00A7C5FCF4; Tue, 21 Mar 2017 23:30:06 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8AF81E002B; Tue, 21 Mar 2017 23:30:03 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 5BEF9C402CA; Tue, 21 Mar 2017 23:30:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1275261426509555680==" MIME-Version: 1.0 Subject: Re: Review Request 57794: HIVE-16260 : Remove parallel edges between semijoin and mpajoin From: Deepak Jaiswal To: Jason Dere Cc: Deepak Jaiswal , hive Date: Tue, 21 Mar 2017 23:30:03 -0000 Message-ID: <20170321233003.2629.32673@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Deepak Jaiswal X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57794/ X-Sender: Deepak Jaiswal References: <20170320215901.9563.73069@reviews-vm2.apache.org> In-Reply-To: <20170320215901.9563.73069@reviews-vm2.apache.org> Reply-To: Deepak Jaiswal X-ReviewRequest-Repository: hive-git archived-at: Tue, 21 Mar 2017 23:30:12 -0000 --===============1275261426509555680== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57794/ ----------------------------------------------------------- (Updated March 21, 2017, 11:30 p.m.) Review request for hive and Jason Dere. Changes ------- Implemented changes recommended. Bugs: HIVE-16260 https://issues.apache.org/jira/browse/HIVE-16260 Repository: hive-git Description ------- Remove parallel edges between semijoin and mpajoin. Added some extra config to tweak toe bloomfilter size and disable semijoin if bigtable is small. Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 62908f9 ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java c513ee5 ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 47b229f ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBloomFilter.java 788aace ql/src/test/queries/clientpositive/dynamic_partition_pruning.q d28da6e ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q 5482cdb ql/src/test/queries/clientpositive/dynamic_semijoin_reduction_2.q 2306395 ql/src/test/queries/clientpositive/dynamic_semijoin_reduction_3.q 01650f8 ql/src/test/queries/clientpositive/mergejoin.q eecd105 ql/src/test/queries/clientpositive/vectorized_dynamic_partition_pruning.q d2ded71 ql/src/test/queries/clientpositive/vectorized_dynamic_semijoin_reduction.q 68b57ea ql/src/test/queries/clientpositive/vectorized_dynamic_semijoin_reduction2.q be8e4af ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out 96d998f ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out d32cb5c ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out 5f75977 ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_3.q.out c272fc1 ql/src/test/results/clientpositive/llap/mergejoin.q.out ae99e66 ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out 0182a46 ql/src/test/results/clientpositive/llap/vectorized_dynamic_semijoin_reduction.q.out e62d913 ql/src/test/results/clientpositive/llap/vectorized_dynamic_semijoin_reduction2.q.out d9fd706 ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 32609eb ql/src/test/results/clientpositive/tez/explainuser_3.q.out da52b0a Diff: https://reviews.apache.org/r/57794/diff/2/ Changes: https://reviews.apache.org/r/57794/diff/1-2/ Testing ------- Thanks, Deepak Jaiswal --===============1275261426509555680==--