Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1E602200C32 for ; Thu, 9 Mar 2017 11:05:24 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1CF03160B67; Thu, 9 Mar 2017 10:05:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 660C8160B64 for ; Thu, 9 Mar 2017 11:05:23 +0100 (CET) Received: (qmail 92209 invoked by uid 500); 9 Mar 2017 10:05:22 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 92198 invoked by uid 99); 9 Mar 2017 10:05:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 10:05:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BA9F818049D; Thu, 9 Mar 2017 10:05:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id lPe0Ki6PmJIJ; Thu, 9 Mar 2017 10:05:20 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 309A05FBC1; Thu, 9 Mar 2017 10:05:20 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id F1142E002C; Thu, 9 Mar 2017 10:05:15 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E1881C400C2; Thu, 9 Mar 2017 10:05:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9031749048736900480==" MIME-Version: 1.0 Subject: Re: Review Request 57343: HIVE-16127 Separate database initialization from actual query run in TestBeeLineDriver From: Peter Vary To: Barna Zsombor Klara , Vihang Karajgaonkar , Sergio Pena , Zoltan Haindrich , Naveen Gangam Cc: Peter Vary , hive Date: Thu, 09 Mar 2017 10:05:15 -0000 Message-ID: <20170309100515.27210.44683@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Peter Vary X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57343/ X-Sender: Peter Vary References: <20170308150315.19287.68@reviews-vm2.apache.org> In-Reply-To: <20170308150315.19287.68@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/beeline/drop_with_concurrency.q.out X-ReviewBoard-Diff-For: beeline/src/java/org/apache/hive/beeline/util/QFileClient.java X-ReviewBoard-Diff-For: itests/util/src/main/java/org/apache/hive/beeline/qfile/QFile.java X-ReviewBoard-Diff-For: itests/util/src/main/java/org/apache/hive/beeline/qfile/QFileBeeLineClient.java X-ReviewBoard-Diff-For: itests/util/src/main/java/org/apache/hive/beeline/qfile/package-info.java Reply-To: Peter Vary X-ReviewRequest-Repository: hive-git archived-at: Thu, 09 Mar 2017 10:05:24 -0000 --===============9031749048736900480== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57343/ ----------------------------------------------------------- (Updated March 9, 2017, 10:05 a.m.) Review request for hive, Zoltan Haindrich, Naveen Gangam, Sergio Pena, Vihang Karajgaonkar, and Barna Zsombor Klara. Changes ------- Addressed review comments, rebased to head Bugs: HIVE-16127 https://issues.apache.org/jira/browse/HIVE-16127 Repository: hive-git Description ------- Refactored the QFileClient: - Moved to itest/util - Separated QFile specific code parts (file path, and filtering) - Separated BeeLineClient specific code (execution of the queries, commands) - Created factories for QFile, and Client, so after initialization they can be reused during multiple tests - Separated init script run from actual test run, so multiple tests could be run against a single MiniHS2 instance - Removed unused property Diffs (updated) ----- beeline/src/java/org/apache/hive/beeline/util/QFileClient.java d99483e itests/src/test/resources/testconfiguration.properties 2a7627a itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java aba1fde itests/util/src/main/java/org/apache/hive/beeline/qfile/QFile.java PRE-CREATION itests/util/src/main/java/org/apache/hive/beeline/qfile/QFileBeeLineClient.java PRE-CREATION itests/util/src/main/java/org/apache/hive/beeline/qfile/package-info.java PRE-CREATION ql/src/test/results/clientpositive/beeline/drop_with_concurrency.q.out PRE-CREATION Diff: https://reviews.apache.org/r/57343/diff/3/ Changes: https://reviews.apache.org/r/57343/diff/2-3/ Testing ------- Used the previosly generated test to validate that the result is not changed. Added one more test to check the separation is done correctly. Thanks, Peter Vary --===============9031749048736900480==--