Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8FACB200C30 for ; Tue, 7 Mar 2017 18:17:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8E33B160B68; Tue, 7 Mar 2017 17:17:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D906E160B65 for ; Tue, 7 Mar 2017 18:17:07 +0100 (CET) Received: (qmail 66652 invoked by uid 500); 7 Mar 2017 17:17:06 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 66641 invoked by uid 99); 7 Mar 2017 17:17:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Mar 2017 17:17:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 34190C0C0D; Tue, 7 Mar 2017 17:17:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.749 X-Spam-Level: *** X-Spam-Status: No, score=3.749 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id P7KXOJzya6j6; Tue, 7 Mar 2017 17:17:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E2EE95FE0B; Tue, 7 Mar 2017 17:17:03 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 08EA2E0156; Tue, 7 Mar 2017 17:17:03 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id ED118C41201; Tue, 7 Mar 2017 17:17:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3603748081184469793==" MIME-Version: 1.0 Subject: Re: Review Request 57274: HIVE-16102 From: Ashutosh Chauhan To: Ashutosh Chauhan Cc: hive , =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= Date: Tue, 07 Mar 2017 17:17:02 -0000 Message-ID: <20170307171702.19286.99507@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Ashutosh Chauhan X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57274/ X-Sender: Ashutosh Chauhan References: <20170307095548.58010.24847@reviews-vm2.apache.org> In-Reply-To: <20170307095548.58010.24847@reviews-vm2.apache.org> Reply-To: Ashutosh Chauhan X-ReviewRequest-Repository: hive-git archived-at: Tue, 07 Mar 2017 17:17:08 -0000 --===============3603748081184469793== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57274/#review168151 ----------------------------------------------------------- ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out Lines 292-312 (original), 292-312 (patched) Is this correct? Oracle returns grouping_id = 0 for all the rows here (which looks incorrect, too). Ran on oracle: select grouping_id(department_id, gender,education_level), department_id, gender, education_level from employee group by department_id, gender, education_level, grouping sets (department_id, gender, education_level, (education_level, department_id)); - Ashutosh Chauhan On March 7, 2017, 9:55 a.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57274/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 9:55 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-16102 > https://issues.apache.org/jira/browse/HIVE-16102 > > > Repository: hive-git > > > Description > ------- > > HIVE-16102 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 2ffc1306e727ccde15e507a2bd087d9e964e734e > ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java be561cef8fdec2fc9fdc194e1c4771497582c5a9 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveExpandDistinctAggregatesRule.java 82624fc33f31f742b25f0a6887efabe7e2834947 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java db8d46e2dca44605a4068c27b4be9f13401f46b0 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0872e535a9b6a09569c02fc498dab16867ca8783 > ql/src/test/queries/clientpositive/multi_count_distinct.q 855cb64c889e4c4309eaf9ee0745f528e611bd54 > ql/src/test/queries/clientpositive/multi_count_distinct_null.q 442d855d86129f0725f4b7c50df59e25c6c6b6cc > ql/src/test/results/clientnegative/groupby_grouping_sets1.q.out 8290d4c4686455b9b689c8de876e765d5859a111 > ql/src/test/results/clientnegative/groupby_grouping_sets2.q.out 8290d4c4686455b9b689c8de876e765d5859a111 > ql/src/test/results/clientpositive/cte_1.q.out d13ad42a19d866b9a701d02d0bac0d62fb2a3dfa > ql/src/test/results/clientpositive/groupby_cube1.q.out 0486b689f62a98bf2994b2f1d964a36e85b707d2 > ql/src/test/results/clientpositive/groupby_grouping_id1.q.out 9ef76155be18f103063fea699d78029acbec1300 > ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out 6917dbabb96b5a582416ac7f07968b739823a13f > ql/src/test/results/clientpositive/groupby_grouping_window.q.out 202fad093fee28bdbf347e9d89b61ada5dfaa72f > ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out d740dea0d6c0b4b284afab3d6f13032407351a3f > ql/src/test/results/clientpositive/llap/cte_1.q.out 1e6a4385d3f26a5e4ffa502688a95da977d0a4ae > ql/src/test/results/clientpositive/llap/groupby_grouping_id2.q.out 9c85852863cf4bc858e1b30511764fa33ac57ece > ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out 0cbb9deba0ed6a33faa122b9d6d75fccdcbc6bfb > ql/src/test/results/clientpositive/llap/vector_grouping_sets.q.out 21769170d948ebf576367fc30861101d0c4f5423 > ql/src/test/results/clientpositive/spark/groupby_cube1.q.out 56b8c2f382840bdc05afffceae1c8b7b1dd6b776 > ql/src/test/results/clientpositive/spark/groupby_grouping_id2.q.out 9c85852863cf4bc858e1b30511764fa33ac57ece > ql/src/test/results/clientpositive/tez/multi_count_distinct.q.out ef3fcabb4c4184831ba06d9017a68d5fd2a7c687 > ql/src/test/results/clientpositive/vector_grouping_sets.q.out df4631e5f3434be99ebb063e2ff0c45383928f7f > > > Diff: https://reviews.apache.org/r/57274/diff/3/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > > --===============3603748081184469793==--