hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 57094: HIVE-15996
Date Wed, 29 Mar 2017 23:19:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57094/#review170498
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
Line 3091 (original), 3096 (patched)
<https://reviews.apache.org/r/57094/#comment243337>

    This should be 1



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
Lines 3111 (patched)
<https://reviews.apache.org/r/57094/#comment243338>

    Add a comment for this statement.



ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out
Lines 1070-1085 (patched)
<https://reviews.apache.org/r/57094/#comment243339>

    Needs updating, now that undelying bug is fixed.


- Ashutosh Chauhan


On Feb. 27, 2017, 2:37 p.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57094/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 2:37 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-15996
>     https://issues.apache.org/jira/browse/HIVE-15996
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15996
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0872e535a9b6a09569c02fc498dab16867ca8783

>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGrouping.java cc015268de0ab1e32401c1cf7c21502fb2a45331

>   ql/src/test/queries/clientpositive/groupby_grouping_sets_grouping.q 78560978ccb84c0737decf45cb56810195be288d

>   ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out 6917dbabb96b5a582416ac7f07968b739823a13f

> 
> 
> Diff: https://reviews.apache.org/r/57094/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message