hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vihang Karajgaonkar <vih...@cloudera.com>
Subject Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection
Date Wed, 22 Mar 2017 23:47:05 GMT


> On March 22, 2017, 8:31 p.m., Vihang Karajgaonkar wrote:
> > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
> > Line 392 (original), 381 (patched)
> > <https://reviews.apache.org/r/57632/diff/4/?file=1670926#file1670926line395>
> >
> >     Does code does not fallback to initMetricsReported() if initCodahaleMetricsReporterClasses()
throws an exception?
> 
> Sunitha Beeram wrote:
>     I would like to fall back to the deprecated config only if the new one is not available
- in which case the method returns false (not an exception). But if it is present and we encounter
issues with it, I would like to not fall back at that time, ie, the intent is only backwards
compatibility and not to support multiple confs at the same time. Let me know if you think
otherwise.

I think thats fine. Just wanted to make sure if it was intentional.


- Vihang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/#review169775
-----------------------------------------------------------


On March 21, 2017, 4:05 p.m., Sunitha Beeram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57632/
> -----------------------------------------------------------
> 
> (Updated March 21, 2017, 4:05 p.m.)
> 
> 
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
> 
> 
> Bugs: Hive-16206
>     https://issues.apache.org/jira/browse/Hive-16206
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16206: Address review comments
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
e8abf6cf06afc9fa590af3a447eacc67735a69e6 
>   common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1fb32533d58af4ec622feb320bf9315da5db6e76

>   common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
> 
> 
> Diff: https://reviews.apache.org/r/57632/diff/4/
> 
> 
> Testing
> -------
> 
> Updated unit tests and all unit tests passed locally.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message