hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sunitha Beeram via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection
Date Wed, 22 Mar 2017 23:31:21 GMT


> On March 21, 2017, 4:31 p.m., Ratandeep Ratti wrote:
> > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
> > Lines 74 (patched)
> > <https://reviews.apache.org/r/57632/diff/3/?file=1669357#file1669357line74>
> >
> >     What all exception types are thrown here? Is it possible to act on some of these?

This is a comment on the older version of the file - I've broken down exception handling in
the next revision. Let me know if you still have concerns.


- Sunitha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/#review169570
-----------------------------------------------------------


On March 21, 2017, 4:05 p.m., Sunitha Beeram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57632/
> -----------------------------------------------------------
> 
> (Updated March 21, 2017, 4:05 p.m.)
> 
> 
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
> 
> 
> Bugs: Hive-16206
>     https://issues.apache.org/jira/browse/Hive-16206
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16206: Address review comments
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
e8abf6cf06afc9fa590af3a447eacc67735a69e6 
>   common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1fb32533d58af4ec622feb320bf9315da5db6e76

>   common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
> 
> 
> Diff: https://reviews.apache.org/r/57632/diff/4/
> 
> 
> Testing
> -------
> 
> Updated unit tests and all unit tests passed locally.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message