hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Barna Zsombor Klara <zsombor.kl...@cloudera.com>
Subject Re: Review Request 57728: HIVE-16231: Parquet timestamp may be stored differently since HIVE-12767
Date Tue, 21 Mar 2017 17:28:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57728/
-----------------------------------------------------------

(Updated March 21, 2017, 5:28 p.m.)


Review request for hive and Sergio Pena.


Changes
-------

Refactored timezone check into a separate method in DateUtils.


Repository: hive-git


Description
-------

HIVE-16231: Parquet timestamp may be stored differently since HIVE-12767


Diffs (updated)
-----

  common/src/java/org/apache/hive/common/util/DateUtils.java a1068ecce94e9ff1ae78008a0d8c6d67ca4f2690

  common/src/test/org/apache/hive/common/util/TestDateUtils.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/MapredParquetOutputFormat.java 26f1e75c7d659a634cd4eef3a0cb8e886b22722f

  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ParquetRecordReaderBase.java 8e33b7d437894b33b35f32913a3bc02f2a849ce3

  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java 5dc808800290f3274afbdff12134ac34387a746b

  ql/src/test/queries/clientpositive/parquet_int96_timestamp.q 5de2c3f1244b8340b97eb0547fe66e52d80fb065



Diff: https://reviews.apache.org/r/57728/diff/2/

Changes: https://reviews.apache.org/r/57728/diff/1-2/


Testing
-------

Tested loading timestamps from a parquet file written by spark.


Thanks,

Barna Zsombor Klara


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message