hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 57568: HIVE-15978 Support regr_* functions
Date Tue, 14 Mar 2017 23:08:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57568/#review168950
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java
Lines 211 (patched)
<https://reviews.apache.org/r/57568/#comment241265>

    We can instantiate GenericUDAFAverageEvaluatorDecimal by looking at arguments.



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java
Lines 215 (patched)
<https://reviews.apache.org/r/57568/#comment241267>

    See above. Any reason for not supporting decimal?



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java
Lines 255 (patched)
<https://reviews.apache.org/r/57568/#comment241268>

    This implies we can't use corr, correct. This function is not symmetric. We need to be
standard compliant.



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java
Lines 289 (patched)
<https://reviews.apache.org/r/57568/#comment241269>

    Cant use correvaluator then.



ql/src/test/results/clientpositive/udaf_binarysetfunctions.q.out
Lines 399 (patched)
<https://reviews.apache.org/r/57568/#comment241272>

    Testing on postgres, got NULL for covar_samp() instead of 0.0


- Ashutosh Chauhan


On March 13, 2017, 7:56 p.m., Zoltan Haindrich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57568/
> -----------------------------------------------------------
> 
> (Updated March 13, 2017, 7:56 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-15978
>     https://issues.apache.org/jira/browse/HIVE-15978
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> all aggregators have been implemented by using some existing aggregator
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 4ac25c24eb1becf1640d35f5b79965e4aefc5421

>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java
PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDAFBinarySetFunctions.java
PRE-CREATION 
>   ql/src/test/queries/clientpositive/udaf_binarysetfunctions.q PRE-CREATION 
>   ql/src/test/results/clientpositive/show_functions.q.out 1361b9322199bbee5a97b402253e204004bcbfb9

>   ql/src/test/results/clientpositive/udaf_binarysetfunctions.q.out PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57568/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zoltan Haindrich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message