hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <pv...@cloudera.com>
Subject Re: Review Request 57343: HIVE-16127 Separate database initialization from actual query run in TestBeeLineDriver
Date Thu, 09 Mar 2017 10:05:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57343/
-----------------------------------------------------------

(Updated March 9, 2017, 10:05 a.m.)


Review request for hive, Zoltan Haindrich, Naveen Gangam, Sergio Pena, Vihang Karajgaonkar,
and Barna Zsombor Klara.


Changes
-------

Addressed review comments, rebased to head


Bugs: HIVE-16127
    https://issues.apache.org/jira/browse/HIVE-16127


Repository: hive-git


Description
-------

Refactored the QFileClient:
- Moved to itest/util
- Separated QFile specific code parts (file path, and filtering)
- Separated BeeLineClient specific code (execution of the queries, commands)
- Created factories for QFile, and Client, so after initialization they can be reused during
multiple tests
- Separated init script run from actual test run, so multiple tests could be run against a
single MiniHS2 instance
- Removed unused property


Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/util/QFileClient.java d99483e 
  itests/src/test/resources/testconfiguration.properties 2a7627a 
  itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java aba1fde

  itests/util/src/main/java/org/apache/hive/beeline/qfile/QFile.java PRE-CREATION 
  itests/util/src/main/java/org/apache/hive/beeline/qfile/QFileBeeLineClient.java PRE-CREATION

  itests/util/src/main/java/org/apache/hive/beeline/qfile/package-info.java PRE-CREATION 
  ql/src/test/results/clientpositive/beeline/drop_with_concurrency.q.out PRE-CREATION 


Diff: https://reviews.apache.org/r/57343/diff/3/

Changes: https://reviews.apache.org/r/57343/diff/2-3/


Testing
-------

Used the previosly generated test to validate that the result is not changed.
Added one more test to check the separation is done correctly.


Thanks,

Peter Vary


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message