hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <pv...@cloudera.com>
Subject Re: Review Request 57343: HIVE-16127 Separate database initialization from actual query run in TestBeeLineDriver
Date Wed, 08 Mar 2017 15:03:38 GMT


> On March 7, 2017, 3:25 p.m., Barna Zsombor Klara wrote:
> > Thanks for the patch Peter. LGTM (non-binding)

Thanks for the review Zsombor!


> On March 7, 2017, 3:25 p.m., Barna Zsombor Klara wrote:
> > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java
> > Lines 121 (patched)
> > <https://reviews.apache.org/r/57343/diff/1/?file=1658136#file1658136line127>
> >
> >     Is there any reason we can't just call initData() here? The code seems to be
the same.

Refactored, so initdata will take the extra parameters and can be reused.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57343/#review168135
-----------------------------------------------------------


On March 8, 2017, 3:03 p.m., Peter Vary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57343/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 3:03 p.m.)
> 
> 
> Review request for hive, Zoltan Haindrich, Naveen Gangam, Sergio Pena, Vihang Karajgaonkar,
and Barna Zsombor Klara.
> 
> 
> Bugs: HIVE-16127
>     https://issues.apache.org/jira/browse/HIVE-16127
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Refactored the QFileClient:
> - Moved to itest/util
> - Separated QFile specific code parts (file path, and filtering)
> - Separated BeeLineClient specific code (execution of the queries, commands)
> - Created factories for QFile, and Client, so after initialization they can be reused
during multiple tests
> - Separated init script run from actual test run, so multiple tests could be run against
a single MiniHS2 instance
> - Removed unused property
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/util/QFileClient.java d306b7f 
>   itests/src/test/resources/testconfiguration.properties b01ebd8 
>   itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java
aba1fde 
>   itests/util/src/main/java/org/apache/hive/beeline/qfile/QFile.java PRE-CREATION 
>   itests/util/src/main/java/org/apache/hive/beeline/qfile/QFileBeeLineClient.java PRE-CREATION

>   itests/util/src/main/java/org/apache/hive/beeline/qfile/package-info.java PRE-CREATION

>   ql/src/test/results/clientpositive/beeline/drop_with_concurrency.q.out PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/57343/diff/2/
> 
> 
> Testing
> -------
> 
> Used the previosly generated test to validate that the result is not changed.
> Added one more test to check the separation is done correctly.
> 
> 
> Thanks,
> 
> Peter Vary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message