Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============5585427361585744995=="
MIME-Version: 1.0
Subject: Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and
 re-enable
From: Peter Vary <pvary@cloudera.com>
To: Zoltan Haindrich <kirk@rxd.hu>, j.prasanth.j@gmail.com,
 Siddharth Seth <sseth@apache.org>,
 Barna Zsombor Klara <zsombor.klara@cloudera.com>,
 Sergey Shelukhin <sergey@hortonworks.com>,
 Marta Kuczora <kuczoram@cloudera.com>,
 Miklos Csanady <miklos.csanady@cloudera.com>,
 Sergio Pena <sergio.pena@cloudera.com>
Cc: Peter Vary <pvary@cloudera.com>, hive <dev@hive.apache.org>,
 Vihang Karajgaonkar <vihang@cloudera.com>
Date: Fri, 24 Feb 2017 12:21:55 -0000
Message-ID: <20170224122155.1738.59427@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Peter Vary <noreply@reviews.apache.org>
References: <20161019133922.5284.76139@reviews.apache.org>
In-Reply-To: <20161019133922.5284.76139@reviews.apache.org>
Reply-To: Peter Vary <pvary@cloudera.com>
archived-at: Fri, 24 Feb 2017 12:22:03 -0000

--===============5585427361585744995==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/
-----------------------------------------------------------

(Updated Feb. 24, 2017, 12:21 p.m.)


Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.


Changes
-------

Addressed Vihang's comments.

Moved from HiveServer2 to MiniHS2 as a server - this caused some refactoring.
Removed Zookeeper cluster creation but kept it commented out so we can enable it if needed
Added the possibility to change the init/cleanup scripts for the QFileClient
Added some comments


Bugs: HIVE-14459
    https://issues.apache.org/jira/browse/HIVE-14459


Repository: hive-git


Description
-------

Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully.
- Enabled the driver
- Modified the regexps to hide when comparing the results
- Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope
- Added required dependencies to pom
- Added specific results dir for beeline q.out-s


Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e 
  itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/AbstractHiveService.java  
  itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java  
  itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6 
  itests/src/test/resources/testconfiguration.properties d344464 
  itests/util/pom.xml 6d93dc1 
  itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java af8ec67 
  itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3 
  ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/52978/diff/


Testing
-------

Manually on my computer several runs.
Waiting for the QA tests


Thanks,

Peter Vary


--===============5585427361585744995==--