Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D704A200C31 for ; Wed, 22 Feb 2017 00:12:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D598A160B74; Tue, 21 Feb 2017 23:12:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 27C5F160B68 for ; Wed, 22 Feb 2017 00:12:45 +0100 (CET) Received: (qmail 39805 invoked by uid 500); 21 Feb 2017 23:12:39 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 39792 invoked by uid 99); 21 Feb 2017 23:12:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Feb 2017 23:12:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D35BF3224F9; Tue, 21 Feb 2017 23:12:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4698758798011363532==" MIME-Version: 1.0 Subject: Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max From: Sergio Pena To: Sergio Pena , hive , Thomas Poepping Date: Tue, 21 Feb 2017 23:12:38 -0000 Message-ID: <20170221231238.1731.93486@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sergio Pena X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56688/ X-Sender: Sergio Pena References: <20170221224147.2040.79586@reviews.apache.org> In-Reply-To: <20170221224147.2040.79586@reviews.apache.org> Reply-To: Sergio Pena X-ReviewRequest-Repository: hive-git archived-at: Tue, 21 Feb 2017 23:12:46 -0000 --===============4698758798011363532== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 21, 2017, 10:41 p.m., Thomas Poepping wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 2085 > > > > > > The default is already defined in HiveConf, right? Do we need to specify another default here? Yes. This is the only method that is available on Hiveconf - public int getInt(String name, int defaultValue) - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56688/#review166250 ----------------------------------------------------------- On Feb. 21, 2017, 9:01 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56688/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 9:01 p.m.) > > > Review request for hive. > > > Bugs: HIVE-15881 > https://issues.apache.org/jira/browse/HIVE-15881 > > > Repository: hive-git > > > Description > ------- > > Deprecates the use of mapred.dfsclient.parallelism.max, and instead use hive.exec.input.listing.max.threads > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1af59ba5879d3ad24148fa86f8ce725acef2bb63 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java e81cbce3e333d44a4088c10491f399e92a505293 > ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java 5a9d83ca4890a68a63f8f6c145d30906a58c7e73 > > Diff: https://reviews.apache.org/r/56688/diff/ > > > Testing > ------- > > Added tests to TestUtilities. > Waiting for HiveQA > > > Thanks, > > Sergio Pena > > --===============4698758798011363532==--