Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7CBDE200C1E for ; Fri, 17 Feb 2017 13:04:46 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7B457160B55; Fri, 17 Feb 2017 12:04:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C3292160B3F for ; Fri, 17 Feb 2017 13:04:45 +0100 (CET) Received: (qmail 15311 invoked by uid 500); 17 Feb 2017 12:04:44 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 15291 invoked by uid 99); 17 Feb 2017 12:04:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Feb 2017 12:04:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 155323204FA; Fri, 17 Feb 2017 12:04:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0604662439061125396==" MIME-Version: 1.0 Subject: Re: Review Request 56784: HIVE-15928 From: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= To: Slim Bouguerra , Ashutosh Chauhan Cc: hive , =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= Date: Fri, 17 Feb 2017 12:04:43 -0000 Message-ID: <20170217120443.17007.44043@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez_=3Cnoreply=40reviews=2E?=@reviews.apache.org, =?utf-8?q?apache=2Eorg=3E?=@reviews.apache.org X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56784/ X-Sender: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez_=3Cnoreply=40reviews?= =?utf-8?b?LmFwYWNoZS5vcmc+?= References: <20170217112219.17084.60266@reviews.apache.org> In-Reply-To: <20170217112219.17084.60266@reviews.apache.org> Reply-To: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez_=3Cjcamachorodriguez?=@reviews.apache.org, =?utf-8?q?=40hortonworks=2Ecom=3E?=@reviews.apache.org X-ReviewRequest-Repository: hive-git archived-at: Fri, 17 Feb 2017 12:04:46 -0000 --===============0604662439061125396== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56784/#review165927 ----------------------------------------------------------- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 1936) I left current code that goes through Druid broker so we have a predictable backup execution strategy if something goes wrong with new distributed implementation. But we can remove the configuration property and the non-distributed code if you feel strongly about it. druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java (line 207) We should, I will change it accordingly. druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java (line 245) I will do that and upload a new patch. Thanks - Jesús Camacho Rodríguez On Feb. 17, 2017, 11:22 a.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56784/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2017, 11:22 a.m.) > > > Review request for hive, Ashutosh Chauhan and Slim Bouguerra. > > > Bugs: HIVE-15928 > https://issues.apache.org/jira/browse/HIVE-15928 > > > Repository: hive-git > > > Description > ------- > > HIVE-15928 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0bff243f08188c98ffe16c6602f628412881fc66 > druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java 8b378407c4ff7c7764e7d48feb3e4cbe16f82016 > > Diff: https://reviews.apache.org/r/56784/diff/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > > --===============0604662439061125396==--