Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7475A200C17 for ; Fri, 10 Feb 2017 22:52:21 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 73189160B5C; Fri, 10 Feb 2017 21:52:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B9EDB160B4E for ; Fri, 10 Feb 2017 22:52:20 +0100 (CET) Received: (qmail 6173 invoked by uid 500); 10 Feb 2017 21:52:19 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 6156 invoked by uid 99); 10 Feb 2017 21:52:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Feb 2017 21:52:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7C41E2DF989; Fri, 10 Feb 2017 21:52:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2425972704717317603==" MIME-Version: 1.0 Subject: Re: Review Request 56240: HiveParser spends lots of time in parsing queries with lots of "(" From: pengcheng xiong To: Ashutosh Chauhan Cc: pengcheng xiong , hive , Gunther Hagleitner Date: Fri, 10 Feb 2017 21:52:18 -0000 Message-ID: <20170210215218.31773.32678@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: pengcheng xiong X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56240/ X-Sender: pengcheng xiong References: <20170208230126.31774.92951@reviews.apache.org> In-Reply-To: <20170208230126.31774.92951@reviews.apache.org> X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/parenthese.q X-ReviewBoard-Diff-For: ql/src/test/queries/clientnegative/udf_in_2.q X-ReviewBoard-Diff-For: ql/src/test/results/clientnegative/udf_in_2.q.out X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/parenthese.q.out Reply-To: pengcheng xiong X-ReviewRequest-Repository: hive-git archived-at: Fri, 10 Feb 2017 21:52:21 -0000 --===============2425972704717317603== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56240/ ----------------------------------------------------------- (Updated Feb. 10, 2017, 9:52 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description ------- HIVE-15388 Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 1d8c3e0 ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseDriverIntervals.java e5db412 ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBSubQuery.java 311a34d ql/src/test/queries/clientnegative/udf_in_2.q PRE-CREATION ql/src/test/queries/clientpositive/interval_alt.q a4fbe9f ql/src/test/queries/clientpositive/parenthese.q PRE-CREATION ql/src/test/queries/clientpositive/udf_in.q a7ce3c6 ql/src/test/queries/clientpositive/udf_notop.q dceab7e ql/src/test/results/clientnegative/char_pad_convert_fail2.q.out 2d08fb3 ql/src/test/results/clientnegative/invalid_select_expression.q.out 3650ca7 ql/src/test/results/clientnegative/ptf_negative_DistributeByOrderBy.q.out a0f3fe2 ql/src/test/results/clientnegative/ptf_negative_PartitionBySortBy.q.out a0f3fe2 ql/src/test/results/clientnegative/ptf_window_boundaries.q.out 3808f2c ql/src/test/results/clientnegative/ptf_window_boundaries2.q.out 3808f2c ql/src/test/results/clientnegative/subquery_missing_from.q.out eaf7735 ql/src/test/results/clientnegative/subquery_subquery_chain.q.out e661e1b ql/src/test/results/clientnegative/subquery_with_or_cond.q.out 4a9cc45 ql/src/test/results/clientnegative/udf_in.q.out 773230b ql/src/test/results/clientnegative/udf_in_2.q.out PRE-CREATION ql/src/test/results/clientpositive/interval_alt.q.out 04d5874 ql/src/test/results/clientpositive/llap/vector_between_in.q.out 8a4383e ql/src/test/results/clientpositive/parenthese.q.out PRE-CREATION ql/src/test/results/clientpositive/perf/query14.q.out 21cabbc ql/src/test/results/clientpositive/spark/vector_between_in.q.out 4de2eb6 ql/src/test/results/clientpositive/udf_between.q.out 5b01554 ql/src/test/results/clientpositive/udf_in.q.out da07f61 ql/src/test/results/clientpositive/udf_notop.q.out 25483c7 Diff: https://reviews.apache.org/r/56240/diff/ Testing ------- Thanks, pengcheng xiong --===============2425972704717317603==--