Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id ACF88200C14 for ; Tue, 7 Feb 2017 22:32:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AB8E1160B68; Tue, 7 Feb 2017 21:32:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 04E4B160B32 for ; Tue, 7 Feb 2017 22:32:44 +0100 (CET) Received: (qmail 38723 invoked by uid 500); 7 Feb 2017 21:32:44 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 38709 invoked by uid 99); 7 Feb 2017 21:32:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Feb 2017 21:32:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 09A632DF8A7; Tue, 7 Feb 2017 21:32:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0414932902901463089==" MIME-Version: 1.0 Subject: Re: Review Request 56095: HIVE-15754 exchange partition is not generating notifications From: Nachiket Vaidya To: Sergio Pena , hive , Nachiket Vaidya Date: Tue, 07 Feb 2017 21:32:43 -0000 Message-ID: <20170207213243.31773.17875@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Nachiket Vaidya X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56095/ X-Sender: Nachiket Vaidya References: <20170207213208.31774.63249@reviews.apache.org> In-Reply-To: <20170207213208.31774.63249@reviews.apache.org> Reply-To: Nachiket Vaidya X-ReviewRequest-Repository: hive-git archived-at: Tue, 07 Feb 2017 21:32:45 -0000 --===============0414932902901463089== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56095/ ----------------------------------------------------------- (Updated Feb. 7, 2017, 9:32 p.m.) Review request for hive, Mohit Sabharwal and Sergio Pena. Bugs: HIVE-15754 https://issues.apache.org/jira/browse/HIVE-15754 Repository: hive-git Description ------- HIVE-15754 exchange partition is not generating notifications exchange partition event is not generating notifications in notification_log. There should multiple events generated. one add_partition event and several drop_partition events. for example: ALTER TABLE tab1 EXCHANGE PARTITION (part=1) WITH TABLE tab2; There should be the following events: ADD_PARTITION on tab2 on partition (part=1) DROP_PARTITION on tab1 on partition (part=1) Diffs ----- itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 640b567ebf9af1af5a3dd9fa1442eb5c5b8ef1a4 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 13d0aab40eaf344869b8230614b55115f64857e6 Diff: https://reviews.apache.org/r/56095/diff/ Testing ------- o Added unit test cases. o Ran exchange partition queries and saw entired in notification_log. Thanks, Nachiket Vaidya --===============0414932902901463089==--