Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3CBC7200C0F for ; Thu, 2 Feb 2017 23:09:44 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3B54A160B57; Thu, 2 Feb 2017 22:09:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 80848160B44 for ; Thu, 2 Feb 2017 23:09:43 +0100 (CET) Received: (qmail 95792 invoked by uid 500); 2 Feb 2017 22:09:42 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 95775 invoked by uid 99); 2 Feb 2017 22:09:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Feb 2017 22:09:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 221B22DF980; Thu, 2 Feb 2017 22:09:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2065526850051496666==" MIME-Version: 1.0 Subject: Re: Review Request 56140: Can't order by an unselected column From: pengcheng xiong To: Ashutosh Chauhan Cc: pengcheng xiong , hive Date: Thu, 02 Feb 2017 22:09:42 -0000 Message-ID: <20170202220942.1722.91854@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: pengcheng xiong X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56140/ X-Sender: pengcheng xiong References: <20170131224406.5716.93268@reviews.apache.org> In-Reply-To: <20170131224406.5716.93268@reviews.apache.org> X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/order_by_expr.q.out X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/order_by_expr.q Reply-To: pengcheng xiong X-ReviewRequest-Repository: hive-git archived-at: Thu, 02 Feb 2017 22:09:44 -0000 --===============2065526850051496666== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56140/#review164030 ----------------------------------------------------------- ql/src/test/results/clientpositive/llap/explainuser_1.q.out (line 1434) I confirmed with another query without order by. Fetch operator will have limit: 5. Thus, this is correct since there is an order by below it. - pengcheng xiong On Jan. 31, 2017, 10:44 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56140/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2017, 10:44 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-15160 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e9bf3e4 > ql/src/test/queries/clientpositive/order_by_expr.q PRE-CREATION > ql/src/test/results/clientpositive/cp_sel.q.out 6300578 > ql/src/test/results/clientpositive/decimal_stats.q.out 5af58fb > ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out 62f40cd > ql/src/test/results/clientpositive/llap/cbo_limit.q.out c582578 > ql/src/test/results/clientpositive/llap/cbo_rp_limit.q.out c582578 > ql/src/test/results/clientpositive/llap/explainuser_1.q.out b9489eb > ql/src/test/results/clientpositive/llap/vector_decimal_2.q.out 144356c > ql/src/test/results/clientpositive/llap/vector_decimal_round.q.out 8e7cd63 > ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out 391c775 > ql/src/test/results/clientpositive/order_by_expr.q.out PRE-CREATION > ql/src/test/results/clientpositive/perf/query36.q.out b356628 > ql/src/test/results/clientpositive/perf/query70.q.out b4eaee6 > ql/src/test/results/clientpositive/perf/query86.q.out 6377c43 > ql/src/test/results/clientpositive/perf/query89.q.out 7bc8700 > ql/src/test/results/clientpositive/spark/cbo_limit.q.out c582578 > ql/src/test/results/clientpositive/vector_decimal_round.q.out 1e76ba2 > ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out dd4b7d1 > > Diff: https://reviews.apache.org/r/56140/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > > --===============2065526850051496666==--