hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Teddy Choi <pudi...@gmail.com>
Subject Re: Review Request 57083: [HIVE-15939] Make cast expressions comply more to sql2011
Date Tue, 28 Feb 2017 13:23:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57083/
-----------------------------------------------------------

(Updated 2 28, 2017, 1:23 오후)


Review request for hive, Zoltan Haindrich and Zoltan Haindrich.


Bugs: HIVE-15939
    https://issues.apache.org/jira/browse/HIVE-15939


Repository: hive-git


Description
-------

I modified UDFToBoolean to recognize 'true' and 'false' without case sensitivity. I also created
vectorized UDFs.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java bf78251 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToBoolean.java PRE-CREATION

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncStringToLong.java PRE-CREATION

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringLength.java cdaf694

  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java 0cc0c9e 
  ql/src/test/queries/clientpositive/udf_to_boolean.q 8bea7ab 
  ql/src/test/queries/clientpositive/vectorized_udf_to_boolean.q PRE-CREATION 
  ql/src/test/results/clientpositive/udf_to_boolean.q.out ebce364 
  ql/src/test/results/clientpositive/vector_empty_where.q.out 97a0f6a 
  ql/src/test/results/clientpositive/vectorized_udf_to_boolean.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/57083/diff/


Testing
-------

udf_to_boolean.q, vectorized_udf_to_boolean.q


Thanks,

Teddy Choi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message