hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <pv...@cloudera.com>
Subject Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable
Date Fri, 24 Feb 2017 12:23:44 GMT


> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote:
> > beeline/src/java/org/apache/hive/beeline/util/QFileClient.java, line 125
> > <https://reviews.apache.org/r/52978/diff/3/?file=1541458#file1541458line125>
> >
> >     can you please add a comment saying what the filter regex is doing to make it
easier to understand?
> 
> Peter Vary wrote:
>     Will do - This is for removing the timestamp from the begining of the log lines

Done


> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote:
> > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java,
lines 66-68
> > <https://reviews.apache.org/r/52978/diff/3/?file=1541464#file1541464line66>
> >
> >     Not sure why we need this? Can you please add some comment to help us understand
> 
> Peter Vary wrote:
>     To be honest, I was aiming for the minimal change, and did not try to run without
it. Will check - my guess is that the HiveServer configured to use ZK cluster for something.
> 
> Peter Vary wrote:
>     Ok.. Checked, and this is needed if we want to run HiveServer2 with ZookeeperLockManager.
What do you think shall we use EmbeddedLockManager instead?

Commented out, but kept the code, so we can reenable it in time


> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote:
> > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java,
lines 81-86
> > <https://reviews.apache.org/r/52978/diff/3/?file=1541464#file1541464line81>
> >
> >     Is it possible to use miniHS2 instead?
> 
> Peter Vary wrote:
>     This is a very good idea! I think we should do that...
>     The same applies here as above - tried to keep my changes minimal - Shall we change
this here, or in a followup jira to separate the changes?
> 
> Peter Vary wrote:
>     Checked this, using miniHS2 would mean circular dependency. We have to move the CoreBeeLineDriver
to hive-unit module to remove this problem. I think I will ask Zoltan what does he think about
the refactor

Created a refactored version, I still think this a very good idea.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/#review166031
-----------------------------------------------------------


On Feb. 24, 2017, 12:21 p.m., Peter Vary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52978/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2017, 12:21 p.m.)
> 
> 
> Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J,
Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
> 
> 
> Bugs: HIVE-14459
>     https://issues.apache.org/jira/browse/HIVE-14459
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Kept the changes minimal with the sole goal to be able to run the BeeLine query tests
multiple times successfully.
> - Enabled the driver
> - Modified the regexps to hide when comparing the results
> - Configured to run only 1 qtest file - so we can test, and could decide later of the
beeline testing scope
> - Added required dependencies to pom
> - Added specific results dir for beeline q.out-s
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e 
>   itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/AbstractHiveService.java
 
>   itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java  
>   itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java
cb276e6 
>   itests/src/test/resources/testconfiguration.properties d344464 
>   itests/util/pom.xml 6d93dc1 
>   itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java af8ec67

>   itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java
e5144e3 
>   ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52978/diff/
> 
> 
> Testing
> -------
> 
> Manually on my computer several runs.
> Waiting for the QA tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message