hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vihang Karajgaonkar <vih...@cloudera.com>
Subject Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable
Date Sat, 18 Feb 2017 23:17:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52978/#review166031
-----------------------------------------------------------




beeline/src/java/org/apache/hive/beeline/util/QFileClient.java (line 125)
<https://reviews.apache.org/r/52978/#comment237928>

    can you please add a comment saying what the filter regex is doing to make it easier to
understand?



itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java (lines
62 - 64)
<https://reviews.apache.org/r/52978/#comment237931>

    Not sure why we need this? Can you please add some comment to help us understand



itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java (lines
77 - 82)
<https://reviews.apache.org/r/52978/#comment237929>

    Is it possible to use miniHS2 instead?



itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java (line
112)
<https://reviews.apache.org/r/52978/#comment237930>

    Having a fixed port number could become a problem in ptests. May be we should use a port
number which is available in the run time (I think miniHS2 instantiates on a available port
at the run time)


- Vihang Karajgaonkar


On Oct. 19, 2016, 1:39 p.m., Peter Vary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52978/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2016, 1:39 p.m.)
> 
> 
> Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J,
Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara.
> 
> 
> Bugs: HIVE-14459
>     https://issues.apache.org/jira/browse/HIVE-14459
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Kept the changes minimal with the sole goal to be able to run the BeeLine query tests
multiple times successfully.
> - Enabled the driver
> - Modified the regexps to hide when comparing the results
> - Configured to run only 1 qtest file - so we can test, and could decide later of the
beeline testing scope
> - Added required dependencies to pom
> - Added specific results dir for beeline q.out-s
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e 
>   itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java
cb276e6 
>   itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java PRE-CREATION

>   itests/src/test/resources/testconfiguration.properties 97e310d 
>   itests/util/pom.xml 6d93dc1 
>   itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java 366c7b4

>   itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java
e5144e3 
>   ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52978/diff/
> 
> 
> Testing
> -------
> 
> Manually on my computer several runs.
> Waiting for the QA tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message