hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesús Camacho Rodríguez <jcamachorodrig...@hortonworks.com>
Subject Re: Review Request 56784: HIVE-15928
Date Fri, 17 Feb 2017 12:04:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56784/#review165927
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 1936)
<https://reviews.apache.org/r/56784/#comment237778>

    I left current code that goes through Druid broker so we have a predictable backup execution
strategy if something goes wrong with new distributed implementation.
    
    But we can remove the configuration property and the non-distributed code if you feel
strongly about it.



druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java (line
207)
<https://reviews.apache.org/r/56784/#comment237779>

    We should, I will change it accordingly.



druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java (line
245)
<https://reviews.apache.org/r/56784/#comment237780>

    I will do that and upload a new patch. Thanks


- Jesús Camacho Rodríguez


On Feb. 17, 2017, 11:22 a.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56784/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2017, 11:22 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Slim Bouguerra.
> 
> 
> Bugs: HIVE-15928
>     https://issues.apache.org/jira/browse/HIVE-15928
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15928
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0bff243f08188c98ffe16c6602f628412881fc66

>   druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java
8b378407c4ff7c7764e7d48feb3e4cbe16f82016 
> 
> Diff: https://reviews.apache.org/r/56784/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message