hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Chauhan <hashut...@apache.org>
Subject Re: Review Request 56784: HIVE-15928
Date Fri, 17 Feb 2017 11:54:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56784/#review165926
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 1936)
<https://reviews.apache.org/r/56784/#comment237777>

    Any reason for this make configurable? Seems like should always be true.



druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java (line
207)
<https://reviews.apache.org/r/56784/#comment237776>

    Shall we rethrow here? Can we still continue?



druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java (line
245)
<https://reviews.apache.org/r/56784/#comment237775>

    It might be a better idea to pass locatedSD.getLocations() list to HiveDruidSplit and
then override FileSplit::getLocations()/getLocationInfo() there to return this list. 
    
    This will make sure that in colocated cluster, Tez has info to colocate tez tasks with
druid historical node. In current impl, it will make use of dummyPath and will be totally
unpredictable.


- Ashutosh Chauhan


On Feb. 17, 2017, 11:22 a.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56784/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2017, 11:22 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Slim Bouguerra.
> 
> 
> Bugs: HIVE-15928
>     https://issues.apache.org/jira/browse/HIVE-15928
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15928
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0bff243f08188c98ffe16c6602f628412881fc66

>   druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java
8b378407c4ff7c7764e7d48feb3e4cbe16f82016 
> 
> Diff: https://reviews.apache.org/r/56784/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message